Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

killedby is now always an array #3187

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

Edgpaez
Copy link
Contributor

@Edgpaez Edgpaez commented Oct 6, 2021

This PRs remove some code needed to support plugins with and without support for disableBail.
Since most of the plugins support it now it is no longer necessary.

We keep behavior in jest where we only report the first failing test

const runResult: KilledMutantRunResult = {
  status: MutantRunStatus.Killed,
-  killedBy: 'spec-1',
+  killedBy: ['spec-1'],
  failureMessage: 'foo should be bar,
  nrOfTests: 3
}

@nicojs nicojs added this to the 6.0 milestone Feb 13, 2022
@nicojs nicojs changed the base branch from master to epic/esm February 18, 2022 09:48
@nicojs
Copy link
Member

nicojs commented Feb 18, 2022

@Edgpaez thanks for the work! We're going to merge this in the epic/esm branch (which is the Stryker v6 branch)

@nicojs nicojs merged commit c257966 into stryker-mutator:epic/esm Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants