fix(core): report failed check results only once #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Share the replay of failed check results accross all subscribers using the `shareReplay()` rxjs operator. Reporting of a failed checks is done using a side effect (with the `tap()` operator). When later we subscribe to it twice, which is a result of the `partition()` operator, the reporting was done twice.
|
@danny12321 or @ThierryRietveld maybe want to review? |
danny12321
approved these changes
Mar 30, 2022
|
Thanks @danny12321 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share the replay of failed check results accross all subscribers using the
shareReplay()rxjs operator.Reporting of a failed checks is done using a side effect (with the
tap()operator). When later we subscribe to it twice, which is a result of thepartition()operator, the reporting was done twice.Fixes #3461