Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): short circuit test executor when no tests and allowEmpty #4477

Merged
merged 4 commits into from
Oct 22, 2023
Merged

fix(core): short circuit test executor when no tests and allowEmpty #4477

merged 4 commits into from
Oct 22, 2023

Conversation

edno
Copy link
Contributor

@edno edno commented Oct 9, 2023 •
edited
Loading

This should fix #4475 by short circuiting the test executor when no tests found and allowEmpty=true (same behaviour as dryRunOnly):

  • prevent thresholds evaluation
  • avoid unnecessary run of the mutation executor (save some processing time)

@edno edno changed the title fix(core): short circuit test executor when no tests and allowEmpty=true fix(core): short circuit test executor when no tests and allowEmpty Oct 9, 2023
nicojs
nicojs requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. I also like the unit test you've added, could you also add one more (see my remark).

packages/core/test/unit/process/4-mutation-test-executor.spec.ts Show resolved Hide resolved
@edno edno requested a review from nicojs October 20, 2023 12:09
@nicojs nicojs enabled auto-merge (squash) October 22, 2023 20:53
@nicojs
Copy link
Member

nicojs commented Oct 22, 2023

Awesome, Thanks!

@nicojs nicojs merged commit ce3e5cd into stryker-mutator:master Oct 22, 2023
7 checks passed
@edno edno deleted the core/fix-4475 branch October 23, 2023 05:35
This was referenced Jun 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicojs nicojs Awaiting requested review from nicojs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allowEmpty = true exits with error if thresholds is set
2 participants
@edno @nicojs