feat(json config): support json-file config (#1853)

featuring JSON file stryker config It can be the first step to introduce schema for stryker (+ its nice feature I guess)
stryker-mutator · Nov 14, 2019 · 49495ef · 49495ef
1 parent a653514
commit 49495ef
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 4 deletions.
diff --git a/packages/core/src/config/ConfigReader.ts b/packages/core/src/config/ConfigReader.ts
@@ -61,9 +61,14 @@ export default class ConfigReader {
           throw new StrykerError('Invalid config file', e);
         }
       }
-      if (typeof configModule !== 'function') {
-        this.log.fatal('Config file must export a function!\n' + CONFIG_SYNTAX_HELP);
-        throw new StrykerError('Config file must export a function!');
+      if (typeof configModule !== 'function' && typeof configModule !== 'object') {
+        this.log.fatal('Config file must be an object or export a function!\n' + CONFIG_SYNTAX_HELP);
+        throw new StrykerError('Config file must export a function or be a JSON!');
+      }
+      if (typeof configModule === 'object') {
+        return (config: any) => {
+          config.set(configModule);
+        };
       }
     }
 

diff --git a/packages/core/test/integration/config-reader/ConfigReader.it.spec.ts b/packages/core/test/integration/config-reader/ConfigReader.it.spec.ts
@@ -103,7 +103,7 @@ describe(ConfigReader.name, () => {
 
       it('should report a fatal error', () => {
         expect(() => sut.readConfig()).throws();
-        expect(testInjector.logger.fatal).to.have.been.calledWith(`Config file must export a function!
+        expect(testInjector.logger.fatal).to.have.been.calledWith(`Config file must be an object or export a function!
   module.exports = function(config) {
     config.set({
       // your config
@@ -125,5 +125,18 @@ describe(ConfigReader.name, () => {
         expect(() => sut.readConfig()).throws('Invalid config file. Inner error: SyntaxError: Unexpected identifier');
       });
     });
+
+    describe('with json config file', () => {
+      it('should read config file', () => {
+        sut = createSut({ configFile: 'testResources/config-reader/valid.json' });
+
+        result = sut.readConfig();
+
+        expect(result.valid).to.be.eq('config');
+        expect(result.should).to.be.eq('be');
+        expect(result.read).to.be.eq(true);
+        expect(testInjector.logger.warn).not.called;
+      });
+    });
   });
 });
diff --git a/packages/core/testResources/config-reader/valid.json b/packages/core/testResources/config-reader/valid.json
@@ -0,0 +1,5 @@
+{
+  "valid": "config",
+  "should": "be",
+  "read": true
+}