Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ScoreResultCalculator): fix faulty filenames in stryker score result #1165

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

sanderkoenders
Copy link
Member

The filter method used causes a side-effect that creates a corrupt path, I solved this by short circuiting the filter method so it only returns the elements up untill the element that does no longer match.

solves #1140

@simondel
Copy link
Member

simondel commented Oct 1, 2018

Thanks! I'll look at this tomorrow morning

@simondel
Copy link
Member

simondel commented Oct 2, 2018

Looks good to me!

@simondel simondel merged commit 2555f49 into master Oct 2, 2018
@ghost ghost removed the 🔎 Needs review label Oct 2, 2018
@simondel simondel deleted the fix-1140-faulty-filenames-in-score branch October 2, 2018 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants