-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(excludedMutations): Implement new naming of mutators #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicojs
requested changes
Nov 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job man! I love this PR 🌹❤. Just some small remarks. I love the fact that we didn't need to change e2e tests. That strengtens me in the believe that we didn't forget anything
nicojs
reviewed
Nov 22, 2019
Thanks! I've fixed 2 remarks and will merge when green. |
nicojs
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the new mutator names which are defined in the handbook: https://github.com/stryker-mutator/stryker-handbook/blob/master/mutator-types.md
Fixes #1257
Fixes #1866
Migrating:
Almost every mutator has been renamed and/or split. Stryker will warn you about any deprecated mutator names in the
mutator.excludedMutations
section of your config.To migrate, please run stryker to see if your project is affected. If this is the case, please take a look at the mutator types on the handbook (see above).
These are the changes:
New mutations
Due to the migration, some new mutations were added to the javascript mutator.
new Array()
tonew Array([])
[]
to["Stryker was here"]
These mutations were already performed by the typescript mutator.