Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stryker-CLI - create stryker.conf.json file with $schema #2000

Closed
bartekleon opened this issue Jan 31, 2020 · 1 comment · Fixed by #2093
Closed

Stryker-CLI - create stryker.conf.json file with $schema #2000

bartekleon opened this issue Jan 31, 2020 · 1 comment · Fixed by #2093
Labels
🚀 Feature request New feature request
Milestone
3.0

Comments

@bartekleon
Copy link
Member

Since we have pushed schema file for Stryker config, w could use it. My idea is to create JSON file config (which we support too ;) ). And add $schema property so intellisence will give help popups:

{
   "$schema": "url_to_schema_from_schemastore/stryker",
  The rest of the stryker options
}
@bartekleon bartekleon added the 🚀 Feature request New feature request label Jan 31, 2020
@bartekleon bartekleon mentioned this issue Feb 14, 2020
Closed
@nicojs nicojs added this to the 3.0 milestone Feb 14, 2020
@nicojs
Copy link
Member

nicojs commented Feb 14, 2020

Awesome idea! We want to have this in for our v3 release. 👍

@simondel simondel mentioned this issue Mar 11, 2020
Merged
simondel added a commit that referenced this issue Mar 11, 2020
@simondel
feat(Initializer): Initialize config file as JSON by default (#2093)
e07d953 
Fixes #2000 

During initialization, the user is now prompted to ask if they want their config to be in a JSON format instead of js. Both formats now have intellisense as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚀 Feature request New feature request
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

feat(Initializer): Initialize config file as JSON by default stryker-mutator/stryker-js
2 participants
@nicojs @bartekleon