feature(core): Adding appendPlugins commandline option
#2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garethp
force-pushed
the
append-plugins
branch
from
f7e2a03
to
ff1bf9b
Compare
nicojs
requested changes
Aug 17, 2020
Garethp
force-pushed
the
append-plugins
branch
from
629fbfa
to
cfe76a8
Compare
Garethp
force-pushed
the
append-plugins
branch
from
cfe76a8
to
4a3721b
Compare
nicojs
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
I would like to use the appendPlugins option in the e2e tests, that way we know for sure it works as expected. You can choose an existing e2e test for this, maybe one that uses 2 plugins?
I think this can land as is. Please let me know if you want to add that
|
Thanks for the recent changes. Will merge when the pipeline is green, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR for issue #2253