Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stryker not closing correctly with low number of mutants #396

Closed
nicojs opened this issue Sep 27, 2017 · 0 comments · Fixed by #402
Closed

Stryker not closing correctly with low number of mutants #396

nicojs opened this issue Sep 27, 2017 · 0 comments · Fixed by #402

Comments

@nicojs
Copy link
Member

nicojs commented Sep 27, 2017

The latest and greatest Stryker v0.10.2 doesn't seem to close correctly with a low number of mutants. See this example repo:

https://github.com/nicojs/stryker-typescript-issue394

It first creates way too many sandboxes and later only closes the one that actually ran tests (which is 1):

[2017-09-27 08:51:04.545] [INFO] SandboxCoordinator - Creating 7 test runners (based on CPU count)
[2017-09-27 08:51:04.549] [DEBUG] Sandbox - Creating a sandbox for files in C:\z\github\nicojs\stryker-typescript-issue394\.stryker-tmp\sandbox5322435
[2017-09-27 08:51:04.551] [DEBUG] Sandbox - Creating a sandbox for files in C:\z\github\nicojs\stryker-typescript-issue394\.stryker-tmp\sandbox6179253
[2017-09-27 08:51:04.552] [DEBUG] Sandbox - Creating a sandbox for files in C:\z\github\nicojs\stryker-typescript-issue394\.stryker-tmp\sandbox7459993
[2017-09-27 08:51:04.553] [DEBUG] Sandbox - Creating a sandbox for files in C:\z\github\nicojs\stryker-typescript-issue394\.stryker-tmp\sandbox1805168
[2017-09-27 08:51:04.554] [DEBUG] Sandbox - Creating a sandbox for files in C:\z\github\nicojs\stryker-typescript-issue394\.stryker-tmp\sandbox7940097
[2017-09-27 08:51:04.555] [DEBUG] Sandbox - Creating a sandbox for files in C:\z\github\nicojs\stryker-typescript-issue394\.stryker-tmp\sandbox2232950
[2017-09-27 08:51:04.556] [DEBUG] Sandbox - Creating a sandbox for files in C:\z\github\nicojs\stryker-typescript-issue394\.stryker-tmp\sandbox9039988
[2017-09-27 08:51:04.560] [DEBUG] Sandbox - Creating test runner 0 using settings {port: 9234}
[2017-09-27 08:51:04.566] [DEBUG] Sandbox - Creating test runner 1 using settings {port: 9235}
[2017-09-27 08:51:04.571] [DEBUG] Sandbox - Creating test runner 2 using settings {port: 9236}
[2017-09-27 08:51:04.575] [DEBUG] Sandbox - Creating test runner 3 using settings {port: 9237}
[2017-09-27 08:51:04.580] [DEBUG] Sandbox - Creating test runner 4 using settings {port: 9238}
[2017-09-27 08:51:04.585] [DEBUG] Sandbox - Creating test runner 5 using settings {port: 9239}
[2017-09-27 08:51:04.591] [DEBUG] Sandbox - Creating test runner 6 using settings {port: 9240}
nicojs added a commit that referenced this issue Oct 1, 2017
* Rename `SandboxCoordinator` -> `SandboxPool`
* Make sure newly created sandboxes are also disposed if the SandboxPool is already disposed

fixes #396
simondel pushed a commit that referenced this issue Oct 3, 2017
* Rename `SandboxCoordinator` -> `SandboxPool`
* Make sure newly created sandboxes are also disposed if the SandboxPool is already disposed

fixes #396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant