fix(InputFileResolver) Fix for potentially wrong order of files #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solve in different order
|
Why did the original code change the order and how does this code fix it? |
| } | ||
| files.forEach(f => resultFiles.push(f)); |
There was a problem hiding this comment.
This was the old way of pusing files to the result array. Per expression a globbing promise get's resolved. The promisses get created in the correct order, but the resolving can happen in any order. The pushing on the resultFiles array will in a random order.
|
See my remarks in the file changed tab. |
|
Was my response clear? Can this PR be closed? |
|
Yes, thanks for the response! |
nicojs
added a commit
that referenced
this pull request
Jul 30, 2016
…solve in different order (#81)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong order when globbing promisses resolve in different order.