Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Add macOS platform to binary release workflow #374

Merged
merged 6 commits into from
Aug 4, 2024

Conversation

aaronleopold
Copy link
Collaborator

This builds off of the work from #369 to close #310

I'll try to test it during the week with some debug commits to trigger the workflow before merging this in

Copy link
Collaborator

@JMicheli JMicheli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

One thing I'm not familiar with in the MacOS context - do you need two binaries, one for Apple Silicon and one for non-Apple hardware?

@aaronleopold
Copy link
Collaborator Author

aaronleopold commented Jul 30, 2024

One thing I'm not familiar with in the MacOS context - do you need two binaries, one for Apple Silicon and one for non-Apple hardware?

Ah yeah, I think you're correct. I'll look more into it this week to see how much would change. It might just be a matter of adding an additional matrix for arm macOS vs intel. I'd rather not mess around with cross compilation if I can help it

@aaronleopold
Copy link
Collaborator Author

Just because I find it interesting, the builds completed in the following order:

  • macOS (ARM) 11m 32s
  • Ubuntu 13m 20s
  • macOS (intel) 15m 17s
  • Windows 24m 1s

@DieselTech
Copy link

Interesting but weird at the same time. Then again rustup on windows is a bit jank.

@aaronleopold aaronleopold marked this pull request as ready for review August 4, 2024 00:24
@aaronleopold
Copy link
Collaborator Author

Just verified the arm binary worked as expected, so I reverted the debug commit to trigger the workflow and I'll merge this momentarily. Thanks for the catch @JMicheli!

@aaronleopold aaronleopold merged commit 7fc059f into develop Aug 4, 2024
5 checks passed
@aaronleopold aaronleopold deleted the al/macos-binary branch August 4, 2024 00:29
@aaronleopold aaronleopold mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants