-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 Add macOS
platform to binary release workflow
#374
Conversation
f4b761d
to
05b78b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
One thing I'm not familiar with in the MacOS context - do you need two binaries, one for Apple Silicon and one for non-Apple hardware?
Ah yeah, I think you're correct. I'll look more into it this week to see how much would change. It might just be a matter of adding an additional matrix for arm macOS vs intel. I'd rather not mess around with cross compilation if I can help it |
4e16786
to
c5db1ab
Compare
Just because I find it interesting, the builds completed in the following order:
|
Interesting but weird at the same time. Then again |
Just verified the arm binary worked as expected, so I reverted the debug commit to trigger the workflow and I'll merge this momentarily. Thanks for the catch @JMicheli! |
This builds off of the work from #369 to close #310
I'll try to test it during the week with some debug commits to trigger the workflow before merging this in