💄 Improve light theme palette and refactor design system #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronleopold
force-pushed
the
al/improve-theme
branch
from
cc2b67e
to
be48215
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
|
I've been messing around locally doing testing and haven't spotted any missed UI elements from the refactor, so I'll merge this in a moment. I'm sure there's something going missed somewhere, but this should be more than good for now to avoid LOADS of conflicts as I tackle the new stuff |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #321
Relates to #347
PR mainly refactors the color classes according to a more semantic token system taken from Shopify's Polaris design system: https://polaris.shopify.com/tokens/color
Additionally, I've minimally fixed the stylistic concerns wrt column pinning (see #372). So this can supersede #393