From 3fd7053988a3174a0c9d00c4bb21c09a52ae216d Mon Sep 17 00:00:00 2001
From: Stefan Weil <sw@weilnetz.de>
Date: Tue, 20 Jul 2021 16:35:07 +0200
Subject: [PATCH] Implement WeightMatrix::Serialize for TFloat

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 src/lstm/weightmatrix.cpp | 28 +++++++++++-----------------
 1 file changed, 11 insertions(+), 17 deletions(-)

diff --git a/src/lstm/weightmatrix.cpp b/src/lstm/weightmatrix.cpp
index ba7b8653e7..530578f3fb 100644
--- a/src/lstm/weightmatrix.cpp
+++ b/src/lstm/weightmatrix.cpp
@@ -231,7 +231,7 @@ const int kInt8Flag = 1;
 const int kAdamFlag = 4;
 // Flag on mode to indicate that this weightmatrix uses TFloat. Set
 // independently of kInt8Flag as even in int mode the scales can
-// be float or TFloat.
+// be float or double.
 const int kDoubleFlag = 128;
 
 // Writes to the given file. Returns false in case of error.
@@ -246,25 +246,19 @@ bool WeightMatrix::Serialize(bool training, TFile *fp) const {
     if (!wi_.Serialize(fp)) {
       return false;
     }
-    // The scales stored in memory have an extra factor applied to them
-    // to allow faster operation. We have to remove that factor here
-    // before writing to disc.
-    auto scales = scales_;
-    for (auto &scale : scales) {
-      scale *= INT8_MAX;
-    }
-    uint32_t size = scales.size();
+    uint32_t size = scales_.size();
     if (!fp->Serialize(&size)) {
       return false;
     }
-#ifdef FAST_FLOAT
-    assert(!"not implemented");
-    return false;
-#else
-    if (!fp->Serialize(&scales[0], size)) {
-      return false;
+    for (auto scale : scales_) {
+      // The scales stored in memory have an extra factor applied to them
+      // to allow faster operation. We have to remove that factor here
+      // before writing to disc.
+      double value = scale * INT8_MAX;
+      if (!fp->Serialize(&value)) {
+        return false;
+      }
     }
-#endif
   } else {
     if (!tesseract::Serialize(fp, wf_)) {
       return false;
@@ -348,7 +342,7 @@ bool WeightMatrix::DeSerialize(bool training, TFile *fp) {
 bool WeightMatrix::DeSerializeOld(bool training, TFile *fp) {
 #ifdef FAST_FLOAT
   // Not implemented.
-  assert(!"not implemented");
+  ASSERT_HOST(!"not implemented");
   return false;
 #else
   if (int_mode_) {