Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Web3.js injection dependency [BOUNTY $100] #3

Closed
fulldecent opened this issue Jun 29, 2019 · 6 comments
Closed

Remove Web3.js injection dependency [BOUNTY $100] #3

fulldecent opened this issue Jun 29, 2019 · 6 comments

Comments

@fulldecent
Copy link
Member

fulldecent commented Jun 29, 2019

Tenthousandsu.com currently relies on MetaMask's injected Web3.js dependency.

This approach is no longer recommended by MetaMask and is not compatible with Opera.

Apparently it is "simple" to do. But I can't find documentation of the canonical way to do iit.

Requirements

  • Makes the current tenthousandsu.com website work on Chrome+MetaMask AND iOS+Opera
  • Loads Web3.js from a reliable CDN that many other people are using
  • Does not change build process (we will not switch to npm for this)
  • Minimizes impact on existing code

References:


other random notes

Make su squares work on Opera

Add these notes to the issue tracker

WHAT DOES METAMASK USE?

web3.version.api

0.20.3

git rev-parse v0.20.6
cd1cfd9db6cacb494884a1824f8562c6440f85df
git checkout cd1cfd9db6cacb494884a1824f8562c6440f85df

TWEET

Made minor updates to Su Squares white paper

BUILD WEB3JS

git clone [email protected]:ethereum/web3.js.git
cd web3.js
git rev-parse v1.0.0-beta.55
git checkout 3e4427940be4aa897d33c3ecb559d8cec9179e2b

# FROM README
npm install # install all dependencies for npm run bootstrap
npm run bootstrap # install all dependencies and symlinks the internal modules for all modules
npm run build # runs rollup
npm run test # runs all tests 
npm run clean # removes all the node_modules folders in all modules
npm run dev # runs rollup with a watcher

ISSUES

web3/web3.js#2729

web3/web3.js#2623

web3/web3.js#2013

web3/web3.js#2839

https://www.reddit.com/r/ethereum/comments/44vd3f/exact_steps_to_connect_web3js_to_html_page_so_i/

https://explorer.bounties.network/bounty/2326

https://ethereum.stackexchange.com/questions/25651/what-is-the-metamask-workaround-if-web3-is-deprecated


https://raw.githubusercontent.com/ethereum/web3.js/v0.20.6/dist/web3.min.js

https://raw.githubusercontent.com/ethereum/web3.js/cd1cfd9db6cacb494884a1824f8562c6440f85df/dist/web3.min.js

curl ‘https://raw.githubusercontent.com/ethereum/web3.js/cd1cfd9db6cacb494884a1824f8562c6440f85df/dist/web3.min.js’ | openssl dgst -sha384 -binary | openssl base64 -A

rXHfd7f1o1jpr3t+dYI17CkzUY3Wswo1OGbiXPGSbg4s2E42+jkRgllwt7ss2Vlq

https://cdn.jsdelivr.net/gh/ethereum/[email protected]/dist/web3.min.js

https://www.srihash.org

<script src="https://cdn.jsdelivr.net/gh/ethereum/[email protected]/dist/web3.min.js" integrity_no="sha384-rXHfd7f1o1jpr3t+dYI17CkzUY3Wswo1OGbiXPGSbg4s2E42+jkRgllwt7ss2Vlq" crossorigin="anonymous"></script>
@fulldecent fulldecent changed the title Remove Web3.js injection dependency [BOUNTY $50] Remove Web3.js injection dependency [BOUNTY $100] Oct 4, 2019
@owocki
Copy link

owocki commented Nov 19, 2019

we just did this over at gitcoin; heres a PR if you want to copy it => gitcoinco/web#5432

@fulldecent
Copy link
Member Author

Cool thank you, I'll check it out

@wbt
Copy link

wbt commented Jul 4, 2020

Is this still Open?

@fulldecent
Copy link
Member Author

Yes.

@wbt
Copy link

wbt commented Jul 6, 2020

Is the bounty as well (active or increased, since it wasn't enough before)? It's marked 5 months expired.

@fulldecent
Copy link
Member Author

Bounty is still active as is.

Not sure where you are seeing expired. But this issue here and my commitment to pay this bounty is active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants