Add support for integer formats int32 and int64 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit range of generated numbers for this integer subtype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit range of generated numbers for these integer subtypes.
They are well known by OpenAPI: https://swagger.io/docs/specification/data-models/data-types/#numbers
Note Number has larger absolute range than int64, but numbers outside MAX_SAFE_INTEGER and MIN_SAFE_INTEGER range are rounded. To avoid wierd behavior, I've set limits for int64 to these SAFE constraints.
I've added asserts to tests, but since numbers are random-generated, they are not really conclusive.. I've ran tests 100 times to make sure its likely correct.