Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deployment within a custom namespace #1040

Closed
3 tasks
nyechiel opened this issue Jan 21, 2021 · 8 comments
Closed
3 tasks

Support deployment within a custom namespace #1040

nyechiel opened this issue Jan 21, 2021 · 8 comments
Labels

Comments

@nyechiel
Copy link
Member

nyechiel commented Jan 21, 2021

Some deployment model require installation of components within a specific Kubernetes namespace. For e.g, OpenShift Dedicated dictates that any add-on based offering needs to run on its own exclusive namespace, such as openshift-storage.

Today, we use submariner-operator by default, and I don't think that we validated a deployment (as well as other life cycle management events, such as upgrade, and metrics) with a different custom namespace.

  • Custom broker ns by adding --namesapce flag to deploy-broker cmd and in BrokerSpec Depends on Add --broker-namespace flag to deploy-broker #1682
  • Custom operator ns by adding --namespace flag to join cmd and not store it in broker
  • Relevant changes in operator, helm, bundle and packagemanifests
@nyechiel nyechiel added enhancement New feature or request ocs+dedicated labels Jan 21, 2021
@nyechiel nyechiel changed the title Support deployment within a custom namespace support Support deployment within a custom namespace Jan 22, 2021
@dfarrell07 dfarrell07 added this to the 0.9-m1 milestone Jan 28, 2021
@nyechiel nyechiel modified the milestones: 0.9-m1, 0.9-m2 Feb 22, 2021
@nyechiel nyechiel removed this from the 0.9-m2 milestone Mar 3, 2021
@dfarrell07
Copy link
Member

Here's a little test showing changing the broker NS in the operator doesn't break anything: dfarrell07#1

@tpantelis tpantelis self-assigned this May 4, 2021
@SteveMattar
Copy link

SteveMattar commented May 24, 2021

The namespace submariner-k8s-broker is a constant

func NewBrokerNamespace() *v1.Namespace {
ns := &v1.Namespace{
ObjectMeta: metav1.ObjectMeta{
Name: SubmarinerBrokerNamespace,
},
}
return ns
}

@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 21, 2021
@tpantelis tpantelis removed the wontfix This will not be worked on label Sep 21, 2021
@skitt
Copy link
Member

skitt commented Sep 22, 2021

This is required to support multiple clustersets in OCM.

@nyechiel
Copy link
Member Author

@skitt @donaldh is this actually done now or do we have any other gaps to track?

@skitt
Copy link
Member

skitt commented Feb 21, 2022

@skitt @donaldh is this actually done now or do we have any other gaps to track?

We still have hard-coded namespaces in various places, e.g. https://github.com/submariner-io/submariner-operator/blob/devel/internal/constants/constants.go#L24

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

This PR/issue depends on:

@nyechiel
Copy link
Member Author

nyechiel commented Jul 6, 2022

Done.

@nyechiel nyechiel closed this as completed Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants