-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support deployment within a custom namespace #1040
Comments
Here's a little test showing changing the broker NS in the operator doesn't break anything: dfarrell07#1 |
The namespace submariner-operator/pkg/broker/namespace.go Lines 30 to 38 in b52cf2d
|
This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions. |
This is required to support multiple clustersets in OCM. |
We still have hard-coded namespaces in various places, e.g. https://github.com/submariner-io/submariner-operator/blob/devel/internal/constants/constants.go#L24 |
This PR/issue depends on:
|
Done. |
Some deployment model require installation of components within a specific Kubernetes namespace. For e.g, OpenShift Dedicated dictates that any add-on based offering needs to run on its own exclusive namespace, such as openshift-storage.
Today, we use
submariner-operator
by default, and I don't think that we validated a deployment (as well as other life cycle management events, such as upgrade, and metrics) with a different custom namespace.--namesapce
flag todeploy-broker
cmd and inBrokerSpec
Depends on Add --broker-namespace flag to deploy-broker #1682--namespace
flag tojoin
cmd and not store it in brokerThe text was updated successfully, but these errors were encountered: