Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadbalancerIP and annotation to submariner LB service #2322

Open
jbperrin88 opened this issue Mar 1, 2023 · 9 comments
Open

Add loadbalancerIP and annotation to submariner LB service #2322

jbperrin88 opened this issue Mar 1, 2023 · 9 comments
Labels
enhancement New feature or request help wanted Looking for someone to work on this

Comments

@jbperrin88
Copy link

Hi there,

I would like to know if it'll be possible to add custom parameter for the loadBalancing service inside 'kind: Submariner'

We have no external Loadbalancing in our openshift cluster but we use MetalLB.
It would be really usedfull to set MetalLB annotation and loadbalancerIP inside submariner service

Best regards

@jbperrin88 jbperrin88 added the enhancement New feature or request label Mar 1, 2023
@sridhargaddam
Copy link
Member

Hello @jbperrin88,

Can you elaborate it a bit, so that we know the use-case better?
Like what kind of annotation you are looking at and why is it necessary etc.

@jbperrin88
Copy link
Author

jbperrin88 commented Mar 2, 2023

When you use MetalLB , you need to define IpPool and set inside your service definition some custom information:

  • type : LoadBalancer
  • loadBalancerIp: XXX.XXX.XXX.XXX or annotation 'metallb.universe.tf/loadBalancerIPs: XXX.XXX.XXX.XXX'
  • custom annotation like:
    'metallb.universe.tf/address-pool: poolName '

https://metallb.universe.tf/usage/example/

Inside submariner , you can already set 'type : LoadBalancer' when you force loadbalancer mode true.

I was trying to use it, by changing paramter inside the service defined by submariner but it'll be cound be override at anytime because i was using Operator install. (OLM)

If i instal only with SUBCTL , I may customize the service like i want.

Regards

@dfarrell07
Copy link
Member

What resource are you labeling?

@dfarrell07
Copy link
Member

dfarrell07 commented Apr 4, 2023

Talking about this on the PR scrub, it seems this will require changes across the operator and main repos (at least). It would be good if we can make an enhancement proposal to figure out the changes, scope, before starting. @jbperrin88

https://github.com/submariner-io/enhancements/blob/devel/template.md

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 17, 2023
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label Sep 19, 2023
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 18, 2024
@dfarrell07 dfarrell07 added help wanted Looking for someone to work on this and removed stale labels Jan 23, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 23, 2024
@dfarrell07
Copy link
Member

This relates to if we want to use LB for bare metal deployments. Note also submariner-io/shipyard#1622.

@dfarrell07 dfarrell07 removed the stale label May 28, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 26, 2024
@maayanf24 maayanf24 removed the stale label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Looking for someone to work on this
Projects
Status: Backlog
Development

No branches or pull requests

5 participants