Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISTHMUS] Function Signatures Include Outdated opt #121

Closed
vbarua opened this issue Jan 18, 2023 · 2 comments
Closed

[ISTHMUS] Function Signatures Include Outdated opt #121

vbarua opened this issue Jan 18, 2023 · 2 comments

Comments

@vbarua
Copy link
Member

vbarua commented Jan 18, 2023

Plans generated with Isthmus currently include opt_ as a prefix in function signatures.

For example

./isthmus -c "CREATE TABLE persons (zip INT)" "SELECT zip + 1 FROM persons"

creates the follow plan (elided for brevity)

{
  "extensionUris": [{
    "extensionUriAnchor": 1,
    "uri": "/functions_arithmetic.yaml"
  }],
  "extensions": [{
    "extensionFunction": {
      "extensionUriReference": 1,
      "functionAnchor": 0,
      "name": "add:opt_i32_i32"
    }
  }],
  ...
}

in which the + operators is named "add:opt_i32_i32"

The current spec for Function Signature Compound Names no longer includes opt.
This was removed as part of substrait-io/substrait#342.

Isthmus should be updated to omit the opt_ prefix to match the spec.

@vbarua
Copy link
Member Author

vbarua commented Jan 19, 2023

Related to #18

@vbarua
Copy link
Member Author

vbarua commented Jan 30, 2023

Addressed by #124

@vbarua vbarua closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant