From ff68ec98e924aa179f6992aea264e1536c7e9e6a Mon Sep 17 00:00:00 2001
From: Arttu Voutilainen <avoutilainen@palantir.com>
Date: Wed, 26 Jun 2024 16:49:04 +0200
Subject: [PATCH] feat: add null input handling options for nth_value

nth_value can be used in place of e.g. first() in Spark
but it's missing an option for whether to ignore nulls in
input or not
---
 extensions/functions_aggregate_generic.yaml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/extensions/functions_aggregate_generic.yaml b/extensions/functions_aggregate_generic.yaml
index 4d891e9c5..4db63ec32 100644
--- a/extensions/functions_aggregate_generic.yaml
+++ b/extensions/functions_aggregate_generic.yaml
@@ -32,6 +32,11 @@ aggregate_functions:
     impls:
       - args:
           - name: x
-            value: any
+            value: any1
+        options:
+          ignore_nulls:
+            values: [ "TRUE", "FALSE" ]
         nullability: DECLARED_OUTPUT
-        return: any?
+        decomposable: MANY
+        intermediate: any1?
+        return: any1?