fix: Rename Version fields which conflict with <sys/sysmacros.h>

[bkietz]

BREAKING CHANGE: renamed Version.{major -> major_number, minor -> minor_number}

BREAKING CHANGE: renamed Version.{patch -> patch_number} for consistency

[CLAassistant]

All committers have signed the CLA.

[bkietz]

fixes #361

[westonpace]

I don't think there has been widespread integration with the plan version feature yet so this is probably a good time to make this kind of change.

protocolbuffers/protobuf#4654 is probably related but it isn't clear to me if they are saying they aren't going to fix it or if it's already been fixed. What version of protoc are you using? Does using an updated version fix it?

I'm +1 on this change. I don't see much reason not to do it and, even if it can be avoided someway, it's probably best to reduce the number of things users may potentially have to work around.

[westonpace]

Regarding the failures:

At the moment, I think we require both proper semantic messages (including "breaking change") in the both the PR title/description and the commits. Pretty much all PRs squash everything into one commit. I don't remember if that is required or not however. It may be possible to continue as long as each individual commit is properly formatted.

[bkietz]

I don't see any reference to this in CHANGES.txt which does list similar fixes.

From protocolbuffers/protobuf#4654 there's one comment saying we just need to rename things. There's another comment claiming this is fixed, but that is from Apr 2020 -> circa version 3.12.0. I'm still seeing the issue

$ protoc --version
libprotoc 3.19.4

[westonpace]

Formally marking my +1 but since this is a breaking spec change we need 1 other approval.

[cpcloud]

Thanks!