Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename regex_string_split to regexp_string_split #393

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix: rename regex_string_split to regexp_string_split #393

merged 1 commit into from
Nov 30, 2022

Conversation

ianmcook
Copy link
Contributor

@ianmcook ianmcook commented Nov 28, 2022 •
edited
Loading

BREAKING CHANGE: renamed function regex_string_split to regexp_string_split for consistency

@ianmcook
Copy link
Contributor Author

@richtia this is super minor, but I noticed the name of this function you added in #346 used regex_ in the function name, whereas all the others use regexp_. This adds the p for consistency.

richtia
richtia approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@richtia richtia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@jacques-n
Copy link
Contributor

I'm +1 on this. @cpcloud or @westonpace , can you also reply since this is a breaking change?

@westonpace
Copy link
Member

+1 as well

@cpcloud
Copy link
Contributor

cpcloud commented Nov 29, 2022

+1 from me too

@richtia richtia merged commit f9f4967 into substrait-io:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacques-n jacques-n jacques-n approved these changes

@martin-g martin-g martin-g approved these changes

@richtia richtia richtia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ianmcook @jacques-n @westonpace @cpcloud @martin-g @richtia