feat: update interval_day function extensions to include precision param #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacques-n
requested review from
cpcloud,
westonpace,
EpsilonPrime and
vbarua
as code owners
EpsilonPrime
approved these changes
Aug 12, 2024
vbarua
approved these changes
Aug 12, 2024
| @@ -281,31 +281,31 @@ scalar_functions: | |||
| - name: x | |||
| value: timestamp | |||
| - name: y | |||
| value: interval_day | |||
| value: interval_day<P> | |||
| return: timestamp | |||
There was a problem hiding this comment.
Possible not super relevant as we're slowly deprecating timestamp, but given that timestamp has microsecond precision should this function only apply to interval_day<6> values, or this implicit in the output having a microsecond precision?
There was a problem hiding this comment.
i would assume we'd allow any type but the output would always be reduced to precision 6.
mostly inclined not to worry about since this type is going away anyway.
EpsilonPrime
pushed a commit
that referenced
this pull request
Aug 21, 2024
Fixes a bug in `functions_datetime.yaml` that makes it un-parseable by substrait-java, introduced in #679. The `?` for nullability must come before the parameters: https://substrait.io/types/type_parsing/#type-syntax-parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.