TypeScript Definition

[dmzza]

Could you add a TypeScript definition file for this add-on?

I'm new to TypeScript, so this could be wrong, but this is what I used:

export const name: string;

export default class Modifier {
  element: Element
  didInsertElement(positional?: Array<any>, named?: Object): void
  didRecieveArguments(positional?: Array<any>, named?: Object): void
  didUpdateArguments(positional?: Array<any>, named?: Object): void
  willDestroyElement(positional?: Array<any>, named?: Object): void

  static modifier(klass: typeof Modifier): any
}

[sukima]

I haven't a clue about TypeScript. I more new then you are.

Does this work for you? I'm happy to just merge it as is. Can I do that?

[dmzza]

Yes, it works for me, but now I've refined this TypeScript definition to be even more specific. I'll make a PR for it.

[josemarluedke]

For reference: here is the types I'm using with the latest changes for ember-class-based-modifier.

declare module 'ember-class-based-modifier' {
  interface Args<TNamed, TPositional> {
    named: TNamed;
    positional: TPositional;
  }

  export default class Modifier<TNamed = object, TPositional = unknown[]> {
    public args: Args<TNamed, TPositional>;

    public element: HTMLElement | SVGElement;
    public isDestroyed: boolean;
    public isDestroying: boolean;

    public constructor(owner: unknown, args: Args<TNamed, TPositional>);

    public didInstall(): void;
    public didReceiveArguments(): void;
    public didUpdateArguments(): void;
    public willRemove(): void;
    public willDestroy(): void;
  }
}