Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Contact us" button to the About page sidebar #1389

Open
4 tasks
ggeisler opened this issue Jan 13, 2022 · 3 comments
Open
4 tasks

Add a "Contact us" button to the About page sidebar #1389

ggeisler opened this issue Jan 13, 2022 · 3 comments

Comments

@ggeisler
Copy link
Contributor

Issue #1388 proposes to hide the "Contact us" link from the brand bar at the sm breakpoint and narrower. Ideally, however, we still want users who access the site at those narrow breakpoints to be able to see we have a way to provide feedback and to use the existing feedback form.

The proposal in this ticket is to add a new "Contact us" button to the About page sidebar, at the bottom of the Contacts section:

Screen Shot 2022-01-13 at 1 17 26 PM

Selecting this button would trigger the same action as the current brand bar "Contact us" link.

Although we could restrict displaying this button to only the sm breakpoint and narrower (since the brand bar "Contact us" link will be visible in wider viewports), I think we probably should display it in any breakpoint because a user who sees it in the About page sidebar at a narrow viewport and then uses a desktop-width browser window might be confused if they can't find it in the same place they previously saw it.

The potential issue with showing it in two places is deciding how the two trigger locations interact. In other words, if I open the feedback form via the "Contact us" button in the about page sidebar and then, while the form is open, select the "Contact us" link in the brand bar, what happens? If possible, I think the form should close in that scenario. That is, the two triggers behave as if they were a single trigger, either opening or closing the form based on the current open/close state of the form, not based on which trigger is used.

Specific requirements:

  • Add a button with the label "Contact us" to the end of the "Contacts" section of the About page sidebar
  • Use the same button styling as the "Back to search" button on the search results page (hopefully this is just using the btn btn-outline-secondary class)
  • Ensure the behavior of the button is the same as the current "Contact us" link in the brand bar, toggling display of the feedback form
  • Ensure that when the feedback form is open, selecting either the "Contact us" link in the brand bar or this new "Contact us" button closes the form, and vice-versa.

The button in context (after #1388 hides the "Contact us" link on smaller viewports, and #1372 hides the "Sign in" link) should look roughly like this:

Screen Shot 2022-01-13 at 12 50 49 PM

@jcoyne
Copy link
Contributor

jcoyne commented Jan 25, 2023

@ggeisler should this go in Spotlight? Would Spotlight benefit from this?

@ggeisler
Copy link
Contributor Author

This design was a result of very specific feedback from QNL. They expressed concerns, such as the two hamburger menus visible on mobile, that I've not heard expressed by anyone else. I think they were more concerned with the visibility of the Feedback action on mobile than most institutions will be. So in my view, no, I don't think this is a common-enough concern to do it in Spotlight.

@jcoyne
Copy link
Contributor

jcoyne commented Feb 13, 2023

How will this behave if they add a second contact in the exhibit management screen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Todo
Development

No branches or pull requests

3 participants