Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when used with Flask 2.2 #19

Open
AghastComet opened this issue Aug 4, 2022 · 1 comment · May be fixed by #21
Open

Error when used with Flask 2.2 #19

AghastComet opened this issue Aug 4, 2022 · 1 comment · May be fixed by #21

Comments

@AghastComet
Copy link

The flask function 'send_file', used on line 173 of tfviewer.py, doesn't use the 'attachment_filename' keyword as of Flask 2.2. It seems to have been replaced with the 'download_name' keyword.
@AghastComet
Copy link
Author

This could be fixed while maintaining backwards compatibility by checking flask.version first and deciding which keyword to send based on that.

@justinlim812 justinlim812 linked a pull request Apr 14, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change "attachment_filename" to "download_name" justinlim812/tfrecord-viewer
1 participant
@AghastComet