fix(components): Force consistent height of Select across browsers #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #444 +/- ##
=========================================
+ Coverage 74.49% 74.5% +0.01%
=========================================
Files 163 163
Lines 2290 2291 +1
Branches 389 389
=========================================
+ Hits 1706 1707 +1
Misses 462 462
Partials 122 122
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## canary #444 +/- ##
=========================================
+ Coverage 74.49% 74.5% +0.01%
=========================================
Files 163 163
Lines 2290 2291 +1
Branches 389 389
=========================================
+ Hits 1706 1707 +1
Misses 462 462
Partials 122 122
|
glemmal
approved these changes
Jul 23, 2019
|
🎉 This PR is included in version 1.1.0-canary.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
On Firefox, the Select component is two pixels taller than on other browsers. Firefox includes the border-width in the overall height of the element despite box-sizing: border-box.
Approach and changes
Definition of done