feat: Add optional "referencedTable" parameter to OR PostGREST filter #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the PostGREST documentation on embedded filters here |
mpross512
changed the title
grdsdev
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Thanks for the contribution.
Can tou please add a test case for the or method call with a referenced table in https://github.com/supabase-community/supabase-swift/blob/main/Tests/PostgRESTTests/BuildURLRequestTests.swift
Thank you.
grdsdev
approved these changes
Feb 29, 2024
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
When using the or filter, the columns have to be in the table referenced in the "from" clause
What is the new behavior?
Users can now specify an optional "referencedTable" parameter to the or filter, allowing the or to reference other tables besides the main table in the "from" clause.
Additional context