From 4b043275dd2d94600a8138d4ebf4638754ed926b Mon Sep 17 00:00:00 2001
From: Joel Lee <lee.yi.jie.joel@gmail.com>
Date: Fri, 9 Aug 2024 16:22:05 +0800
Subject: [PATCH] fix: remove TOTP field for phone enroll response (#1717)

## What kind of change does this PR introduce?

Make TOTPObject a pointer so that it is not returned in the case of an
`EnrollResponse` for phone
---
 internal/api/mfa.go | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/internal/api/mfa.go b/internal/api/mfa.go
index 35bdd193e..ea3894d68 100644
--- a/internal/api/mfa.go
+++ b/internal/api/mfa.go
@@ -39,11 +39,11 @@ type TOTPObject struct {
 }
 
 type EnrollFactorResponse struct {
-	ID           uuid.UUID  `json:"id"`
-	Type         string     `json:"type"`
-	FriendlyName string     `json:"friendly_name"`
-	TOTP         TOTPObject `json:"totp,omitempty"`
-	Phone        string     `json:"phone,omitempty"`
+	ID           uuid.UUID   `json:"id"`
+	Type         string      `json:"type"`
+	FriendlyName string      `json:"friendly_name"`
+	TOTP         *TOTPObject `json:"totp,omitempty"`
+	Phone        string      `json:"phone,omitempty"`
 }
 
 type ChallengeFactorParams struct {
@@ -246,7 +246,7 @@ func (a *API) enrollTOTPFactor(w http.ResponseWriter, r *http.Request, params *E
 		ID:           factor.ID,
 		Type:         models.TOTP,
 		FriendlyName: factor.FriendlyName,
-		TOTP: TOTPObject{
+		TOTP: &TOTPObject{
 			// See: https://css-tricks.com/probably-dont-base64-svg/
 			QRCode: buf.String(),
 			Secret: key.Secret(),