feat: add timeout middleware #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8829292642Details
💛 - Coveralls |
hf
force-pushed
the
j0/add_timeout_middleware
branch
from
f3d692d
to
4bd26b1
Compare
hf
force-pushed
the
j0/add_timeout_middleware
branch
2 times, most recently
from
9d4d500
to
a79dab0
Compare
hf
force-pushed
the
j0/add_timeout_middleware
branch
from
a79dab0
to
840b30c
Compare
kangmingtay
reviewed
Apr 25, 2024
hf
reviewed
Apr 25, 2024
kangmingtay
force-pushed
the
j0/add_timeout_middleware
branch
from
b200f00
to
1ec8152
Compare
kangmingtay
reviewed
Apr 25, 2024
kangmingtay
approved these changes
Apr 25, 2024
hf
pushed a commit
that referenced
this pull request
Apr 25, 2024
🤖 I have created a release *beep* *boop* --- ## [2.150.0](v2.149.0...v2.150.0) (2024-04-25) ### Features * add support for Azure CIAM login ([#1541](#1541)) ([1cb4f96](1cb4f96)) * add timeout middleware ([#1529](#1529)) ([f96ff31](f96ff31)) * allow for postgres and http functions on each extensibility point ([#1528](#1528)) ([348a1da](348a1da)) * merge provider metadata on link account ([#1552](#1552)) ([bd8b5c4](bd8b5c4)) * send over user in SendSMS Hook instead of UserID ([#1551](#1551)) ([d4d743c](d4d743c)) ### Bug Fixes * return error if session id does not exist ([#1538](#1538)) ([91e9eca](91e9eca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hf
added a commit
that referenced
this pull request
May 22, 2024
#1529 introduced timeout middleware, but it appears from working in the wild it has some race conditions that are not particularly helpful. This PR rewrites the implementation to get rid of race conditions, at the expense of slightly higher RAM usage. It follows the implementation of `http.TimeoutHandler` closely. --------- Co-authored-by: Kang Ming <[email protected]>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
A new middleware is introduced that enforces a strict timeout by using `context.WithTimeout()`. When the timeout is reached, a 504 JSON error with the `request_timeout` error code is sent. Anything that depends on the context is cancelled. --------- Co-authored-by: Kang Ming <[email protected]>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.150.0](supabase/auth@v2.149.0...v2.150.0) (2024-04-25) ### Features * add support for Azure CIAM login ([supabase#1541](supabase#1541)) ([1cb4f96](supabase@1cb4f96)) * add timeout middleware ([supabase#1529](supabase#1529)) ([f96ff31](supabase@f96ff31)) * allow for postgres and http functions on each extensibility point ([supabase#1528](supabase#1528)) ([348a1da](supabase@348a1da)) * merge provider metadata on link account ([supabase#1552](supabase#1552)) ([bd8b5c4](supabase@bd8b5c4)) * send over user in SendSMS Hook instead of UserID ([supabase#1551](supabase#1551)) ([d4d743c](supabase@d4d743c)) ### Bug Fixes * return error if session id does not exist ([supabase#1538](supabase#1538)) ([91e9eca](supabase@91e9eca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
supabase#1529 introduced timeout middleware, but it appears from working in the wild it has some race conditions that are not particularly helpful. This PR rewrites the implementation to get rid of race conditions, at the expense of slightly higher RAM usage. It follows the implementation of `http.TimeoutHandler` closely. --------- Co-authored-by: Kang Ming <[email protected]>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
A new middleware is introduced that enforces a strict timeout by using `context.WithTimeout()`. When the timeout is reached, a 504 JSON error with the `request_timeout` error code is sent. Anything that depends on the context is cancelled. --------- Co-authored-by: Kang Ming <[email protected]>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.150.0](supabase/auth@v2.149.0...v2.150.0) (2024-04-25) ### Features * add support for Azure CIAM login ([supabase#1541](supabase#1541)) ([1cb4f96](supabase@1cb4f96)) * add timeout middleware ([supabase#1529](supabase#1529)) ([f96ff31](supabase@f96ff31)) * allow for postgres and http functions on each extensibility point ([supabase#1528](supabase#1528)) ([348a1da](supabase@348a1da)) * merge provider metadata on link account ([supabase#1552](supabase#1552)) ([bd8b5c4](supabase@bd8b5c4)) * send over user in SendSMS Hook instead of UserID ([supabase#1551](supabase#1551)) ([d4d743c](supabase@d4d743c)) ### Bug Fixes * return error if session id does not exist ([supabase#1538](supabase#1538)) ([91e9eca](supabase@91e9eca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
supabase#1529 introduced timeout middleware, but it appears from working in the wild it has some race conditions that are not particularly helpful. This PR rewrites the implementation to get rid of race conditions, at the expense of slightly higher RAM usage. It follows the implementation of `http.TimeoutHandler` closely. --------- Co-authored-by: Kang Ming <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new middleware is introduced that enforces a strict timeout by using
context.WithTimeout(). When the timeout is reached, a 504 JSON error with therequest_timeouterror code is sent. Anything that depends on the context is cancelled.