Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove legacy lookup in users for one_time_tokens (phase II) #1569

Merged
merged 6 commits into from
May 17, 2024
Merged

feat: remove legacy lookup in users for one_time_tokens (phase II) #1569

merged 6 commits into from
May 17, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented May 3, 2024

Removes legacy lookups in auth.users for when a corresponding entry in one_time_tokens is not found.

Phase II of the refactor, based on #1558, to be released after it's deployed for a few days.

@hf hf requested a review from a team as a code owner May 3, 2024 15:12
@hf hf force-pushed the hf/phase-ii-ott branch 3 times, most recently from 8b185b5 to 9c90f81 Compare May 3, 2024 15:45
kangmingtay
kangmingtay approved these changes May 8, 2024
View reviewed changes
internal/api/verify_test.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9115947616

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 7 (85.71%) changed or added relevant lines in 2 files are covered.
  • 140 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.3%) to 65.744%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/models/one_time_token.go 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
internal/hooks/auth_hooks.go 3 45.45%
internal/models/errors.go 5 42.65%
internal/models/one_time_token.go 6 66.67%
internal/api/api.go 7 86.28%
internal/api/helpers.go 8 75.61%
internal/api/errors.go 8 70.35%
internal/api/auth.go 10 73.4%
internal/observability/logging.go 18 54.43%
internal/api/context.go 23 77.55%
internal/api/verify.go 52 72.46%
Totals Coverage Status
Change from base Build 8997004849: 0.3%
Covered Lines: 8387
Relevant Lines: 12757
💛 - Coveralls

@kangmingtay kangmingtay merged commit 39ca026 into master May 17, 2024
2 checks passed
@kangmingtay kangmingtay deleted the hf/phase-ii-ott branch May 17, 2024 07:24
@github-actions github-actions bot mentioned this pull request May 17, 2024
Merged
J0 pushed a commit that referenced this pull request May 22, 2024
@github-actions
chore(master): release 2.152.0 (#1574)
b954a48 
🤖 I have created a release *beep* *boop*
---


##
[2.152.0](v2.151.0...v2.152.0)
(2024-05-22)


### Features

* new timeout writer implementation
([#1584](#1584))
([72614a1](72614a1))
* remove legacy lookup in users for one_time_tokens (phase II)
([#1569](#1569))
([39ca026](39ca026))
* update chi version
([#1581](#1581))
([c64ae3d](c64ae3d))
* update openapi spec with identity and is_anonymous fields
([#1573](#1573))
([86a79df](86a79df))


### Bug Fixes

* improve logging structure
([#1583](#1583))
([c22fc15](c22fc15))
* sms verify should update is_anonymous field
([#1580](#1580))
([e5f98cb](e5f98cb))
* use api_external_url domain as localname
([#1575](#1575))
([ed2b490](ed2b490))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@hf @kangmingtay
feat: remove legacy lookup in users for one_time_tokens (phase II) (s…
eb4aef4 
…upabase#1569)

Removes legacy lookups in `auth.users` for when a corresponding entry in
`one_time_tokens` is not found.

Phase II of the refactor, based on supabase#1558, to be released after it's
deployed for a few days.

---------

Co-authored-by: Kang Ming <[email protected]>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@github-actions
chore(master): release 2.152.0 (supabase#1574)
7082882 
🤖 I have created a release *beep* *boop*
---


##
[2.152.0](supabase/auth@v2.151.0...v2.152.0)
(2024-05-22)


### Features

* new timeout writer implementation
([supabase#1584](supabase#1584))
([72614a1](supabase@72614a1))
* remove legacy lookup in users for one_time_tokens (phase II)
([supabase#1569](supabase#1569))
([39ca026](supabase@39ca026))
* update chi version
([supabase#1581](supabase#1581))
([c64ae3d](supabase@c64ae3d))
* update openapi spec with identity and is_anonymous fields
([supabase#1573](supabase#1573))
([86a79df](supabase@86a79df))


### Bug Fixes

* improve logging structure
([supabase#1583](supabase#1583))
([c22fc15](supabase@c22fc15))
* sms verify should update is_anonymous field
([supabase#1580](supabase#1580))
([e5f98cb](supabase@e5f98cb))
* use api_external_url domain as localname
([supabase#1575](supabase#1575))
([ed2b490](supabase@ed2b490))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@hf @kangmingtay @LashaJini
feat: remove legacy lookup in users for one_time_tokens (phase II) (s…
8ce9d47 
…upabase#1569)

Removes legacy lookups in `auth.users` for when a corresponding entry in
`one_time_tokens` is not found.

Phase II of the refactor, based on supabase#1558, to be released after it's
deployed for a few days.

---------

Co-authored-by: Kang Ming <[email protected]>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@github-actions @LashaJini
chore(master): release 2.152.0 (supabase#1574)
88c8d9a 
🤖 I have created a release *beep* *boop*
---


##
[2.152.0](supabase/auth@v2.151.0...v2.152.0)
(2024-05-22)


### Features

* new timeout writer implementation
([supabase#1584](supabase#1584))
([72614a1](supabase@72614a1))
* remove legacy lookup in users for one_time_tokens (phase II)
([supabase#1569](supabase#1569))
([39ca026](supabase@39ca026))
* update chi version
([supabase#1581](supabase#1581))
([c64ae3d](supabase@c64ae3d))
* update openapi spec with identity and is_anonymous fields
([supabase#1573](supabase#1573))
([86a79df](supabase@86a79df))


### Bug Fixes

* improve logging structure
([supabase#1583](supabase#1583))
([c22fc15](supabase@c22fc15))
* sms verify should update is_anonymous field
([supabase#1580](supabase#1580))
([e5f98cb](supabase@e5f98cb))
* use api_external_url domain as localname
([supabase#1575](supabase#1575))
([ed2b490](supabase@ed2b490))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangmingtay kangmingtay kangmingtay approved these changes

@J0 J0 J0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hf @coveralls @J0 @kangmingtay