fix: improve mfa verify logs #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9655757406Details
💛 - Coveralls |
|
@J0 decided not to add the error to the hook input since it doesn't seem to help with the decision around re-verification |
J0
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Looks great! The only concern I have is that revealing the code in the Invalid TOTP code... may make it easier to guess since wrong / mis-typed codes can bear some similarity to the actual code.
Let's seek a secondary opinion from @hf
Otherwise looks good to me. Thanks for putting this together
hf
reviewed
Jun 26, 2024
Pull Request Test Coverage Report for Build 9677521071Details
💛 - Coveralls |
J0
pushed a commit
that referenced
this pull request
Jul 3, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.0](v2.154.2...v2.155.0) (2024-07-03) ### Features * add `password_hash` and `id` fields to admin create user ([#1641](#1641)) ([20d59f1](20d59f1)) ### Bug Fixes * improve mfa verify logs ([#1635](#1635)) ([d8b47f9](d8b47f9)) * invited users should have a temporary password generated ([#1644](#1644)) ([3f70d9d](3f70d9d)) * upgrade golang-jwt to v5 ([#1639](#1639)) ([2cb97f0](2cb97f0)) * use pointer for `user.EncryptedPassword` ([#1637](#1637)) ([bbecbd6](bbecbd6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * Upgrade the totp library to the latest version * Improve logging when mfa verification fails by returning the validation error internally as well as logging the code used
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.0](supabase/auth@v2.154.2...v2.155.0) (2024-07-03) ### Features * add `password_hash` and `id` fields to admin create user ([supabase#1641](supabase#1641)) ([20d59f1](supabase@20d59f1)) ### Bug Fixes * improve mfa verify logs ([supabase#1635](supabase#1635)) ([d8b47f9](supabase@d8b47f9)) * invited users should have a temporary password generated ([supabase#1644](supabase#1644)) ([3f70d9d](supabase@3f70d9d)) * upgrade golang-jwt to v5 ([supabase#1639](supabase#1639)) ([2cb97f0](supabase@2cb97f0)) * use pointer for `user.EncryptedPassword` ([supabase#1637](supabase#1637)) ([bbecbd6](supabase@bbecbd6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * Upgrade the totp library to the latest version * Improve logging when mfa verification fails by returning the validation error internally as well as logging the code used
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.0](supabase/auth@v2.154.2...v2.155.0) (2024-07-03) ### Features * add `password_hash` and `id` fields to admin create user ([supabase#1641](supabase#1641)) ([20d59f1](supabase@20d59f1)) ### Bug Fixes * improve mfa verify logs ([supabase#1635](supabase#1635)) ([d8b47f9](supabase@d8b47f9)) * invited users should have a temporary password generated ([supabase#1644](supabase#1644)) ([3f70d9d](supabase@3f70d9d)) * upgrade golang-jwt to v5 ([supabase#1639](supabase#1639)) ([2cb97f0](supabase@2cb97f0)) * use pointer for `user.EncryptedPassword` ([supabase#1637](supabase#1637)) ([bbecbd6](supabase@bbecbd6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?