-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: treat empty string as nil in encrypted_password
#1663
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
approved these changes
Jul 17, 2024
hf
force-pushed
the
hf/fix-authenticate-empty-string
branch
from
July 17, 2024 15:31
39c37a9
to
b48e0fa
Compare
Pull Request Test Coverage Report for Build 9977136011Details
💛 - Coveralls |
kangmingtay
pushed a commit
that referenced
this pull request
Jul 17, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.4](v2.155.3...v2.155.4) (2024-07-17) ### Bug Fixes * treat empty string as nil in `encrypted_password` ([#1663](#1663)) ([f99286e](f99286e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
`Authenticate` should treat empty string as nil, as both mean the same thing.
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.4](supabase/auth@v2.155.3...v2.155.4) (2024-07-17) ### Bug Fixes * treat empty string as nil in `encrypted_password` ([supabase#1663](supabase#1663)) ([f99286e](supabase@f99286e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
`Authenticate` should treat empty string as nil, as both mean the same thing.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.4](supabase/auth@v2.155.3...v2.155.4) (2024-07-17) ### Bug Fixes * treat empty string as nil in `encrypted_password` ([supabase#1663](supabase#1663)) ([f99286e](supabase@f99286e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authenticate
should treat empty string as nil, as both mean the same thing.