-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for migration of firebase scrypt passwords #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
commented
Sep 16, 2024
Would prefer if the name for the Firebase scrypt be |
J0
force-pushed
the
j0/add_scrypt_password_hash
branch
2 times, most recently
from
September 25, 2024 06:47
ba549df
to
5d88639
Compare
Pull Request Test Coverage Report for Build 11048130786Details
💛 - Coveralls |
J0
commented
Sep 25, 2024
J0
force-pushed
the
j0/add_scrypt_password_hash
branch
from
September 25, 2024 12:10
df090f3
to
d524770
Compare
J0
commented
Sep 25, 2024
J0
commented
Sep 25, 2024
J0
changed the title
fix: add support for migration of scrypt passwords
feat: add support for migration of firebase scrypt passwords
Sep 25, 2024
hf
reviewed
Sep 25, 2024
hf
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
J0
force-pushed
the
j0/add_scrypt_password_hash
branch
from
September 26, 2024 08:05
d524770
to
e3768ab
Compare
kangmingtay
pushed a commit
that referenced
this pull request
Sep 27, 2024
🤖 I have created a release *beep* *boop* --- ## [2.162.0](v2.161.0...v2.162.0) (2024-09-27) ### Features * add support for migration of firebase scrypt passwords ([#1768](#1768)) ([ba00f75](ba00f75)) ### Bug Fixes * apply authorized email restriction to non-admin routes ([#1778](#1778)) ([1af203f](1af203f)) * magiclink failing due to passwordStrength check ([#1769](#1769)) ([7a5411f](7a5411f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix #1750. Firebase uses a modified version of scrypt We add support for Firebase Scrypt hashes so that developers can move over from Firebase (or similar) without the obligation to force a password reset for all users.
As there is no pre-defined convention for Firebase scrypt hashes, we establish the following:
Developers can extract their hash parameters from the firebase console
For testing and debugging, clone this utility and follow the instructions in
BUILDING
.On MacOS please add the following flags when attempting to build so as to guard against error:
AES_FUNCTION
missingMore details about export from CLI