Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor request params to use generics #1464

Merged
merged 5 commits into from
Mar 4, 2024
Merged

fix: refactor request params to use generics #1464

merged 5 commits into from
Mar 4, 2024

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Mar 3, 2024 •
edited
Loading

What kind of change does this PR introduce?

  • Introduce a new method retrieveRequestParams which makes use of generics to parse a request
  • This will help to simplify parsing a request from:
params := RequestParams{}
body, err := getBodyBytes(r)
if err != nil {
  return nil, badRequestError("Could not read body").WithInternalError(err)
}

if err := json.Unmarshal(body, &params); err != nil {
  return nil, badRequestError("Could not decode request params: %v", err)
}

to

params := &Request{}
err := retrieveRequestParams(req, params)

TODO

  • Add type constraint instead of using any

@kangmingtay kangmingtay requested a review from a team as a code owner March 3, 2024 04:07
@kangmingtay kangmingtay mentioned this pull request Mar 3, 2024
Closed
@kangmingtay kangmingtay merged commit e1cdf5c into master Mar 4, 2024
5 checks passed
@kangmingtay kangmingtay deleted the km/use-generics branch March 4, 2024 03:34
@github-actions github-actions bot mentioned this pull request Mar 4, 2024
Merged
hf pushed a commit that referenced this pull request Mar 5, 2024
@github-actions
chore(master): release 2.144.0 (#1442)
16c6528 
🤖 I have created a release *beep* *boop*
---


##
[2.144.0](v2.143.0...v2.144.0)
(2024-03-04)


### Features

* add configuration for custom sms sender hook
([#1428](#1428))
([1ea56b6](1ea56b6))
* anonymous sign-ins
([#1460](#1460))
([130df16](130df16))
* clean up test setup in MFA tests
([#1452](#1452))
([7185af8](7185af8))
* pass transaction to `invokeHook`, fixing pool exhaustion
([#1465](#1465))
([b536d36](b536d36))
* refactor resource owner password grant
([#1443](#1443))
([e63ad6f](e63ad6f))
* use dummy instance id to improve performance on refresh token queries
([#1454](#1454))
([656474e](656474e))


### Bug Fixes

* expose `provider` under `amr` in access token
([#1456](#1456))
([e9f38e7](e9f38e7))
* improve MFA QR Code resilience so as to support providers like
1Password ([#1455](#1455))
([6522780](6522780))
* refactor request params to use generics
([#1464](#1464))
([e1cdf5c](e1cdf5c))
* revert refactor resource owner password grant
([#1466](#1466))
([fa21244](fa21244))
* update file name so migration to Drop IP Address is applied
([#1447](#1447))
([f29e89d](f29e89d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@kangmingtay
fix: refactor request params to use generics (supabase#1464)
39a167b 
## What kind of change does this PR introduce?
* Introduce a new method `retrieveRequestParams` which makes use of
generics to parse a request
* This will help to simplify parsing a request from:
```go

params := RequestParams{}
body, err := getBodyBytes(r)
if err != nil {
  return nil, badRequestError("Could not read body").WithInternalError(err)
}

if err := json.Unmarshal(body, &params); err != nil {
  return nil, badRequestError("Could not decode request params: %v", err)
}
```
to 
```go
params := &Request{}
err := retrieveRequestParams(req, params)
```

## TODO
- [x] Add type constraint instead of using `any`
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@github-actions
chore(master): release 2.144.0 (supabase#1442)
f1db115 
🤖 I have created a release *beep* *boop*
---


##
[2.144.0](supabase/auth@v2.143.0...v2.144.0)
(2024-03-04)


### Features

* add configuration for custom sms sender hook
([supabase#1428](supabase#1428))
([1ea56b6](supabase@1ea56b6))
* anonymous sign-ins
([supabase#1460](supabase#1460))
([130df16](supabase@130df16))
* clean up test setup in MFA tests
([supabase#1452](supabase#1452))
([7185af8](supabase@7185af8))
* pass transaction to `invokeHook`, fixing pool exhaustion
([supabase#1465](supabase#1465))
([b536d36](supabase@b536d36))
* refactor resource owner password grant
([supabase#1443](supabase#1443))
([e63ad6f](supabase@e63ad6f))
* use dummy instance id to improve performance on refresh token queries
([supabase#1454](supabase#1454))
([656474e](supabase@656474e))


### Bug Fixes

* expose `provider` under `amr` in access token
([supabase#1456](supabase#1456))
([e9f38e7](supabase@e9f38e7))
* improve MFA QR Code resilience so as to support providers like
1Password ([supabase#1455](supabase#1455))
([6522780](supabase@6522780))
* refactor request params to use generics
([supabase#1464](supabase#1464))
([e1cdf5c](supabase@e1cdf5c))
* revert refactor resource owner password grant
([supabase#1466](supabase#1466))
([fa21244](supabase@fa21244))
* update file name so migration to Drop IP Address is applied
([supabase#1447](supabase#1447))
([f29e89d](supabase@f29e89d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@kangmingtay @LashaJini
fix: refactor request params to use generics (supabase#1464)
f043ee1 
## What kind of change does this PR introduce?
* Introduce a new method `retrieveRequestParams` which makes use of
generics to parse a request
* This will help to simplify parsing a request from:
```go

params := RequestParams{}
body, err := getBodyBytes(r)
if err != nil {
  return nil, badRequestError("Could not read body").WithInternalError(err)
}

if err := json.Unmarshal(body, &params); err != nil {
  return nil, badRequestError("Could not decode request params: %v", err)
}
```
to 
```go
params := &Request{}
err := retrieveRequestParams(req, params)
```

## TODO
- [x] Add type constraint instead of using `any`
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@github-actions @LashaJini
chore(master): release 2.144.0 (supabase#1442)
75cff53 
🤖 I have created a release *beep* *boop*
---


##
[2.144.0](supabase/auth@v2.143.0...v2.144.0)
(2024-03-04)


### Features

* add configuration for custom sms sender hook
([supabase#1428](supabase#1428))
([1ea56b6](supabase@1ea56b6))
* anonymous sign-ins
([supabase#1460](supabase#1460))
([130df16](supabase@130df16))
* clean up test setup in MFA tests
([supabase#1452](supabase#1452))
([7185af8](supabase@7185af8))
* pass transaction to `invokeHook`, fixing pool exhaustion
([supabase#1465](supabase#1465))
([b536d36](supabase@b536d36))
* refactor resource owner password grant
([supabase#1443](supabase#1443))
([e63ad6f](supabase@e63ad6f))
* use dummy instance id to improve performance on refresh token queries
([supabase#1454](supabase#1454))
([656474e](supabase@656474e))


### Bug Fixes

* expose `provider` under `amr` in access token
([supabase#1456](supabase#1456))
([e9f38e7](supabase@e9f38e7))
* improve MFA QR Code resilience so as to support providers like
1Password ([supabase#1455](supabase#1455))
([6522780](supabase@6522780))
* refactor request params to use generics
([supabase#1464](supabase#1464))
([e1cdf5c](supabase@e1cdf5c))
* revert refactor resource owner password grant
([supabase#1466](supabase#1466))
([fa21244](supabase@fa21244))
* update file name so migration to Drop IP Address is applied
([supabase#1447](supabase#1447))
([f29e89d](supabase@f29e89d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J0 J0 J0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangmingtay @J0