feat: expose Realtime options on SupabaseClient #377
Conversation
Provide a means to configure RealtimeV2 options
|
Hi @bryandubno this is a nice addition, is there anything I can help to move it forward? What is missing? |
grdsdev
changed the title
Thanks @grdsdev – I just haven't had a chance to run or add any additional unit tests. If you're able to help on that front, I believe this would be ready for review! I do also wonder if it would be better to add to |
| self.connectOnSubscribe = connectOnSubscribe | ||
| } | ||
| } | ||
|
|
||
| public struct Configuration: Sendable { |
There was a problem hiding this comment.
This might be better marked as internal given it's not intended to be accessed by consumers
| @@ -26,26 +48,22 @@ public actor RealtimeClientV2 { | |||
| var disconnectOnSessionLoss: Bool | |||
| var connectOnSubscribe: Bool | |||
| var logger: (any SupabaseLogger)? | |||
|
|
|||
| public init( | |||
There was a problem hiding this comment.
This also might be better marked as internal given it's not intended to be accessed by consumers
Yes please, let's add it to SupabaseClientOptions under a |
|
@bryandubno I've made a few changes to your code and also updated tests. |
Fantastic! I appreciate you pushing this through! |
What kind of change does this PR introduce?
Exposes public Realtime configuration options.
What is the current behavior?
Realtime configuration options are public, but cannot be configured by the client.
What is the new behavior?
Realtime configuration options can now be set by the client.
Additional context
This is not ready to be merged. Tests need to be updated.