fix(auth): prevent from requesting login keychain password os macOS #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grdsdev
approved these changes
Jul 11, 2024
grdsdev
changed the title
|
that was quick! thanks. 🎉 |
|
Hey @ekurutepe getting back to you since you proposed this change, some people are having issues after this change, when using without an access group as you can follow on #516 Do you have any idea why, and a fix for it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR aligns the behavior of KeychainLocalStorage on iOS and macOS.
What is the current behavior?
When one app save an item in KeychainLocalStorage with an access group on macOS, another app/extension with the same access group would not be able to access the item without the user having to enter their login keychain password. On iOS this would work without user having to enter any passwords.
What is the new behavior?
Both on iOS and macOS apps/extensions are able to access keychain items with the shared access group correctly without the user having to enter their password.