Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with history.listen with history@5 #589

Open
adekbadek opened this issue Sep 17, 2022 · 0 comments
Open

Incompatibility with history.listen with history@5 #589

adekbadek opened this issue Sep 17, 2022 · 0 comments

Comments

@adekbadek
Copy link

adekbadek commented Sep 17, 2022 •
edited
Loading

The handleLocationChange function is called as the listener to history.listen. In version 5 of history, it has the signature of (location, action, isFirstRendering), while a history's listener function has a signature of ({action, location}).

This results in a state of shape {location:{location}} (nested) after the @@router/LOCATION_CHANGE action is called.

Fix is to use version 4 of the history package.
@adekbadek adekbadek changed the title Incompatibility with history.listen Incompatibility with history.listen with history@5 Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adekbadek