Render manpages asynchronously using a ThreadPoolExecutor
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Significantly improves the speed of `update_cache()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes significantly improve the speed of
update_cache()by having calls torender_manpage()run in parallel (usingconcurrent.futures.ThreadPoolExecutor).This causes a significant time improvement in
tldr --updatefor the user.On my machine with 12 logical cpu cores (6 physical cpu cores),
ThreadPoolExecutorwill launch 16 threads (using the calculation(os.cpu_count() or 1) + 4). This results in the following time improvements:This means a cache update now runs 476.49% faster.