fix: optional callback may prevent context from finalizing

superfly · Mar 15, 2018 · f4353cc · f4353cc
1 parent c85f3e1
commit f4353cc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/bridge/proxy_stream.ts b/src/bridge/proxy_stream.ts
@@ -62,11 +62,11 @@ export class ProxyStream {
 }
 
 registerBridge("subscribeProxyStream", function (ctx: Context, bridge: Bridge, ref: ivm.Reference<ProxyStream>, cb: ivm.Reference<Function>) {
-  ctx.addCallback(cb)
+  ctx.addReleasable(cb)
   const proxyable = ref.deref({ release: true })
   const stream = proxyable.stream
   if (!stream) {
-    ctx.applyCallback(cb, ["end"])
+    ctx.tryCallback(cb, ["end"])
     return
   }
   stream.on("close", function () {
@@ -79,6 +79,7 @@ registerBridge("subscribeProxyStream", function (ctx: Context, bridge: Bridge, r
     ctx.tryCallback(cb, ["error", err.toString()])
   })
 })
+
 registerBridge("readProxyStream", function (ctx: Context, bridge: Bridge, ref: ivm.Reference<ProxyStream>, cb: ivm.Reference<Function>) {
   const proxyable = ref.deref({ release: true })
   const stream = proxyable.stream

diff --git a/v8env/middleware/google-analytics.js b/v8env/middleware/google-analytics.js
@@ -150,7 +150,7 @@ export default function registerGoogleAnalytics() {
           }
         }
 
-        await fetch(gaCollectURL, {
+        fetch(gaCollectURL, {
           method: "POST",
           headers: {
             "content-type": "application/x-www-form-urlencoded"