feat: @fly/proxy for sending requests to origin servers #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromegn
reviewed
May 18, 2018
v8env/ts/fly/proxy.ts
Outdated
| * origin("https://somehostname.com/path2/to/document.html") | ||
| * ``` | ||
| */ | ||
| rewritePath?: string, |
There was a problem hiding this comment.
I find this option confusing.
I usually associate "rewrite" like "replace". Needs 2 arguments in my opinion. Some kind of "from" and "to".
Also, a regex would be nice. Hell, I guess it should act just like String.prototype.replace!
There was a problem hiding this comment.
I didn't really want to make it that complex since that option only exists to support /mount/ type stuff right now. I did just renamed it to stripPath though, which I think makes a little more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used by adding
require '@fly/proxy'to apps, which pulls in some extra js with webpack to handle proxied requests.