Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE]: Multi tenancy UI dashboard + account linking fixes + telemetry change to include websiteDomain + email verification claim change + extending jwks lifetime #1011

Open
rishabhpoddar opened this issue Jul 10, 2024 · 2 comments

Comments

@rishabhpoddar
Copy link
Contributor

rishabhpoddar commented Jul 10, 2024

📅 Checklist

Release order

  • Python sdk jwks changes
  • Core
  • Dashbaord
  • Node - with backend sdk testing for FDI 3.0
  • add tests for fdi 1.17, 2.0 for backend sdk testing repo - containing apiversion interceptor, tests for includeInNonPublicTenantsByDefault and email verification claims
  • golang release
  • docs updates
  • python release
  • docs type check with python
  • add tests for fdi 1.18, 1.19 for backend sdk testing repo - containing apiversion interceptor, tests for includeInNonPublicTenantsByDefault and email verification claims
  • node release - with backend tests parallelised and compatible with 1.18 and 1.19
  • Docs
  • move dashboard tests from node sdk to backend-sdk-testing
  • update curl commands of release script of core to be as per what is at the bottom of the file below

🔶 Staging

Dev Tag

  • supertokens-core:X.Y
    • core
      • recompile with right version of openjdk
      • check CDI, plugin interface list
      • Add migration script for psql / mysql
      • Make sure no memory leak
      • Make sure new telemtry API is pushed to prod
    • plugin-interface
      • check plugin interface list
    • mysql-plugin
      • check plugin interface list
      • Add migration script for mysql
    • postgresql-plugin
      • check plugin interface list
      • Add migration script for psql
    • mongodb-plugin
      • check plugin interface list
  • supertokens-node:X.Y
  • supertokens-golang:X.Y
    • check CDI, FDI list
    • apiversion telemetry change
    • boxyhq additional config change
    • network interceptor
    • test server for backend-sdk-testing
    • jwks url logic change
    • email veirfication claim logic change
    • jwks refresh lifetime to 4 hours
    • multi tenancy ui
    • account linking fixes
    • add includeInNonPublicTenantsByDefault in ProviderInput
  • supertokens-python:X.Y
    • check CDI, FDI list
    • apiversion telemetry change
    • boxyhq additional config change
    • network interceptor
    • test server for backend-sdk-testing
    • jwks url logic change
    • email veirfication claim logic change
    • jwks refresh lifetime to 4 hours
    • multi tenancy ui
    • account linking fixes
    • add includeInNonPublicTenantsByDefault in ProviderInput
  • supertokens-auth-react:X.Y
    • check FDI list
    • check web-js interface version
    • Updated dependencies to use supertokens-web-js in package.json from npm registry
  • supertokens-web-js:X.Y
    • check FDI list
    • check web-js interface version
    • email verification claim change
  • supertokens-dashboard
  • Test day with team. Get people in the team to read the docs and implement something with the new feature.

Others

  • Example apps in create-supertokens-app CLI
  • Examples apps in supertokens-auth-react. Update try.supertokens and rerun the pr checklist
  • Examples apps in supertokens-node. Update try.supertokens and rerun the pr checklist
  • next.js:canary
  • SuperTokens Jackson SAML example update
  • Merge the with-multi-tenancy-ui branch from rishabhpoddar/multi-tenancy-mfa to the main branch

📚 Documentation (test site)

  • All recipe main documentation update
  • Migration in changelog for node sdk
  • Change all curl snippets to the core to use authorization bearer token instead of api-key
  • Code type checking versions are pointing to X.Y
    • jsEnv
    • goEnv
    • pythonEnv
  • Update table schema in mysql / postgresql section for self hosted
  • website changes (test.supertokens.io)
    • tenant management UI in the feature page
  • https://supertokens.com/docs/thirdpartyemailpassword/pre-built-ui/setup/backend
    • We should make backend setup first in the docs, and then frontend setup.
    • In backend setup, we should only tell users to setup init, middleware, error handler -> visit dashboard login and configure tenant. This means we will have to enable all recipes by default in backend, which is OK i think.
    • In frontend setup, we should always add useDynamicLoginMethod: true, and always init all recipes, so users just have to call init.
  • https://supertokens.com/docs/mfa/backend-setup
    • For MFA, we should tell users to config via dashboard only, and for complex stuff, they can do via code.
  • In dashboard tab, we should remove that it's only for node sdk

🔥 Production

💻 NPM and core release

📚 Documentation

  • Pushed to production
  • Post message on discord about new update
  • Update core-driver-interface-repo
  • Updated swaggerhub CDI spec
  • Updated dashboard spec on swaggerhub
  • Update dashboard spec
  • Update internal contributing guide to move from previous core version to the latest one
  • Auto generate release note on github:
    • supertokens-core
    • supertokens-plugin-interface
    • supertokens-mysql-plugin
    • supertokens-postgresql-plugin
    • supertokens-mongodb-plugin
    • supertokens-node
    • supertokens-golang
    • supertokens-python
    • supertokens-web-js
    • supertokens-auth-react
    • supertokens-dashboard

Contents of running try.supertokens.com script:

docker run -d \
    --restart=always \
    --name try-supertokens \
    --label name=try-supertokens \
    --label type=session-service \
    --label mode=production \
    --log-driver=awslogs --log-opt awslogs-region=ap-south-1 --log-opt awslogs-group=try-supertokens --log-opt awslogs-stream=try-supertokens \
    -e DISABLE_TELEMETRY=true \
    --publish 9999:3567 \
    supertokens/supertokens-postgresql:6.0

sleep 7

curl --location --request POST 'https://try.supertokens.com/recipe/dashboard/user' \
--header 'rid: dashboard' \
--header 'api-key: <YOUR-API-KEY>' \
--header 'Content-Type: application/json' \
--data-raw '{"email": "[email protected]","password": "abcd1234"}'

curl --location --request POST 'https://try.supertokens.com/recipe/dashboard/user' \
--header 'rid: dashboard' \
--header 'api-key: <YOUR-API-KEY>' \
--header 'Content-Type: application/json' \
--data-raw '{"email": "[email protected]","password": "abcd1234"}'

curl --location --request PUT 'https://try.supertokens.com/recipe/multitenancy/tenant/v2' \
--header 'Content-Type: application/json' \
--data-raw '{
    "tenantId": "tenant1",
    "firstFactors": ["emailpassword", "thirdparty"]
}'

curl --location --request PUT 'https://try.supertokens.com/tenant1/recipe/multitenancy/config/thirdparty' \
--header 'Content-Type: application/json' \
--data-raw '{
  "config": {
    "thirdPartyId": "google-workspaces",
    "name": "Google Workspaces",
    "clients": [
      {
        "clientId": "1060725074195-kmeum4crr01uirfl2op9kd5acmi9jutn.apps.googleusercontent.com",
        "clientSecret": "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",
        "additionalConfig": {
            "hd": "*"
        }
      }
    ]
  }
}'


curl --location --request PUT 'https://try.supertokens.com/recipe/multitenancy/tenant/v2' \
--header 'Content-Type: application/json' \
--data-raw '{
    "tenantId": "tenant2",
    "firstFactors": ["emailpassword"]
}'

curl --location --request PUT 'https://try.supertokens.com/recipe/multitenancy/tenant/v2' \
--header 'Content-Type: application/json' \
--data-raw '{
    "tenantId": "tenant3",
    "firstFactors": ["otp-email", "otp-phone", "link-phone", "link-email", "thirdparty"]
}'


curl --location --request PUT 'https://try.supertokens.com/tenant3/recipe/multitenancy/config/thirdparty' \
--header 'Content-Type: application/json' \
--data-raw '{
  "config": {
    "thirdPartyId": "github",
    "name": "GitHub",
    "clients": [
      {
        "clientId": "467101b197249757c71f",
        "clientSecret": "e97051221f4b6426e8fe8d51486396703012f5bd"
      }
    ]
  }
}'
@rishabhpoddar rishabhpoddar changed the title [RELEASE]: Multi tenancy UI dashboard + account linking fixes + telemetry change to include websiteDomain [RELEASE]: Multi tenancy UI dashboard + account linking fixes + telemetry change to include websiteDomain + email verification claim change Jul 10, 2024
@rishabhpoddar rishabhpoddar changed the title [RELEASE]: Multi tenancy UI dashboard + account linking fixes + telemetry change to include websiteDomain + email verification claim change [RELEASE]: Multi tenancy UI dashboard + account linking fixes + telemetry change to include websiteDomain + email verification claim change + extending jwks lifetime Jul 10, 2024
@rishabhpoddar
Copy link
Contributor Author

rishabhpoddar commented Jul 10, 2024

Dashboard issues

  • OIDC discovery endpoint in provider config deosn't have the well-known path and all
  • If i add a provider config via API (like google workspaces), and then I visit that on the dashboard, it does not show the hd in additional config (NOW)
  • supertokens_max_cdi_version should not show up in core config on dashboard (NOW). This will be done via a new annotation in the core like @HideFromDashboard which will prevent it from showing up for self hosted or saas.
  • If I enable third party for a tenant, and then i click on cancel in the popup that it keeps third party enabled. Is that ok? If so, then once third party is enabled, we can directly show the third party selection ui. If the user clicks on cancel there, show a warning on the UI saying that at least one provider must be selected, otherwise an error will be thrown (if no other first factor is enabled).
  • for self hosted users, the config in public tenant are not modifiable at all on the dashboard - pretty bad experience.
  • For saas users, what config will they be able to modify in non root CUD, public app, public tenant? (NOW)
  • If i add a a custom provider, and do not specify any oidc endpoint nor the authorization urls etc, it allows me to save it anyway. We should change the flow to accept third party id and name before, and then based on that, the form should have prefilled values for OIDC or other endpoints, if those are configured in the core or static for this third party id. If they are not configured in the core or static, the then user must fill in OIDC OR (authorization, user info, token exchange).
  • Name should be compulsory for custom SAML and custom OAuth (NOW)
  • When adding SAML provider, the name should not be SAML, but it should give the user an option to choose from a list of names that we have support for (see this), including SAML. Show a drop down (NOW).
  • The API keys config should be hidden from the dashboard? It's a security risk, no? (NOW)
  • For SAML, need to allow users to upload xml and stuff on our dashboard
  • When modifying an existing SAML provider, the urls for authorization and all have undefined instead of the previously provided url (NOW)
  • In provider listing (the ones that are already added), we need to separate out the oauth and saml providers in the UI
  • If i have init passwordless recipe with only email, and then i clikc on otp-phone in mfa, it says "please init passwordless recipe". This is a wrong error message. It should instead say, "please change contact method of passwordless.init on the backend" (in case passwordless is initilaised, else the message right now is fine)
  • First factor is otp-email, second factor is totp and otp-phone. After logging in with first factor, the /auth/mfa screen shows nothing. No error on console either. (NOW)
  • Write down steps for adding new social provider.
  • Drop down for saml name should only be shown if the name is not coming from the backend or we create a new provider. For example, in the curl command, if i set the name to "Mock SAML", the name should show as that in the provider config (NOW)
  • we should show an info that changes in the dashboard will not reflect in the frontend if useDynamicLoginMethods is not set to true (for pre-built UI)
    • this should be updated in the docs as well
  • bug in delete user UI (see screenshot)
Screenshot 2024-07-11 at 11 29 16
  • In the provider config dashboard, if I have overriden the userInfo function, it says "Custom override". Change it to "Cannot edit this because you have provided a custom override"
  • Need to tell users on tenant management UI that frontend's useDynamicLoginMethod: true in our frontend sdk.
  • Issue in search tag while switching tenants (the search results doesn't take search tags into consideration)
  • In provider config UI, need to add placeholders for all fields, so users know what the format is of the various fields. Especially for things like apple private key.
  • One thing also for dashboard is that if someone tries to create a new tenant, we have to tell them it’s a paid feature. Also, if they have not added multi tenancy, it should show them that error properly and not something went wrong.
  • Under the "Secondary Factors" section in the tenant config UI, explain that enabling will require all users in this tenant to setup one of those factors . If you want to do conditional MFA setup and requirement, then override the getMFARequirementForAuth function in the backend sdk config instead and keep these switched off here.
  • with API key, manual save is not working
  • change manual to 'via boxy api'
  • in docs, update boxy curl command to use auto-generated values for tenant and product
  • check for non 200 in getThirdPartyInfo api

@rishabhpoddar
Copy link
Contributor Author

Thoughts on 20th july, 2024

I also thought about how we can change the docs and flow so that by default, users dont have to init stuff on the frontend (pre built ui) and can go to the dashboard directly to start configuring the tenants and login methods. This is possible if we:

  • On the frontend, init all recipes and pre built uis
  • Set usesDynamicLoginMethods: true by default
  • On the backend, init all recipes by default

The issue with the above is that it breaks the flow of setting up:

  • Users would first need to add the backend init, middleware, error handler
  • Connect it to their core (and not try supertokens)
  • create dashboard credentials
  • configure login methods
  • setup frontend

So they get real feedback really late in the setup phase. As opposed to now, where in the first step is setup frontend, and then get to see the pre built UI immediately. Which is why we didn't go ahead with these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant