Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About composition flexbility #10

Open
3 tasks
sveetch opened this issue Oct 7, 2022 · 1 comment
Open
3 tasks

About composition flexbility #10

sveetch opened this issue Oct 7, 2022 · 1 comment
Labels
question Further information is requested

Comments

@sveetch
Copy link
Owner

sveetch commented Oct 7, 2022

Almost everything can be switchable from the composed application and structure except for the templates.

We are in 2022 and DjangoCMS + sekizai required tags (cms_toolbar and render_block) cannot be inside a Django template "block" tag, they MUST be directly in HTML without any tags around (spaceless, block, etc..). It's AWFUL.

It forces to insert these tags in the skeleton without any condition or something else. For a CMS site it's ok to have the CMS stuff in skeleton, since the site menu will depend on it and the cms toolbar is almost ok to have everywhere, even in non CMS page.

The only remaining way to condition the CMS usage in templates is to make it from a cookiecutter variable. However this would work only at the project creation stage, once created it can be enabled or disable from composed applications. I don't see yet any proper solution.

Also, there is some project parts which are not ready yet for composition, commonly this is because CMS is involved without conditions but opposed to the sekizai problem, these parts can be managed with composer to make the CMS usage optional.

  • CMS, Skeleton and sekizai
  • CMS and Initial data
  • CMS and tests
@sveetch sveetch added enhancement New feature or request question Further information is requested and removed enhancement New feature or request labels Oct 7, 2022
@sveetch
Copy link
Owner Author

sveetch commented Oct 8, 2022

For now the only solution is to keep the really necessarily tags in skeleton and mind to documentate the trick to clean them out of skeleton when CMS is not involved anymore in applications.

@sveetch sveetch changed the title CMS integration is not fully switchable About composition flexbility Nov 17, 2022
@sveetch sveetch added the documentation Improvements or additions to documentation label Feb 2, 2023
@sveetch sveetch removed the documentation Improvements or additions to documentation label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant