You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Projects that have upgraded to cmsplugin-blocks>=1.3.0 (currently we are pinned on v1.2.0 but the latter versions are compatibles) will have a wrong diskette definition and their dump will fail to dump.
Note: This is not a bug only related to cmsplugin-blocks, it can happen with any other app. We just only faced with cmsplugin-blocks because of some project using a more recent release.
Also there are some cms plugin apps that are not marked to depend from djangocms, so they would be ordered to be loaded before djangocms, this will lead a loading error (at least, it can lead to other problem outside of diskette). These apps are:
djangocms-audio
djangocms-video
Environment
Describe your environment:
Plateform: Any
Python version: Any
Bireli version: >=0.3.12
To Reproduce
Steps to reproduce the behavior:
Upgrade to cmsplugin-blocks>=1.3.0
Create at least a plugin from cmsplugin-blocks (empty dump won't raise issue)
Dump data
Try to load data
It fails on a message alike "Integrity error: ForeignKey missing"
Expected behavior
I've thought that explicit app model definition for diskette would be better but i think it would lead more often to failures than with relaxed definition (just giving the app name) for majority of apps. Sometime apps may have breaking change that bring an undesirable model but it is probably to happen more rarely than legit new models.
All app configurations should be reviewed to be relaxed and only known undesirable model should be excluded and we stop to explicitly define all app models.
Additional context
I've reported an issue on Diskette emencia/diskette#9 for a check command that would have helped to see this kind of issue.
The text was updated successfully, but these errors were encountered:
Describe the bug
Projects that have upgraded to cmsplugin-blocks>=1.3.0 (currently we are pinned on v1.2.0 but the latter versions are compatibles) will have a wrong diskette definition and their dump will fail to dump.
Note: This is not a bug only related to cmsplugin-blocks, it can happen with any other app. We just only faced with cmsplugin-blocks because of some project using a more recent release.
Also there are some cms plugin apps that are not marked to depend from djangocms, so they would be ordered to be loaded before djangocms, this will lead a loading error (at least, it can lead to other problem outside of diskette). These apps are:
Environment
Describe your environment:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I've thought that explicit app model definition for diskette would be better but i think it would lead more often to failures than with relaxed definition (just giving the app name) for majority of apps. Sometime apps may have breaking change that bring an undesirable model but it is probably to happen more rarely than legit new models.
All app configurations should be reviewed to be relaxed and only known undesirable model should be excluded and we stop to explicitly define all app models.
Additional context
I've reported an issue on Diskette emencia/diskette#9 for a check command that would have helped to see this kind of issue.
The text was updated successfully, but these errors were encountered: