Skip to content
This repository has been archived by the owner on May 5, 2024. It is now read-only.

Support multipart responses or event streams #1

Open
babichjacob opened this issue Nov 25, 2020 · 7 comments
Open

Support multipart responses or event streams #1

babichjacob opened this issue Nov 25, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@babichjacob
Copy link
Member

graphql-helix's README shows an example for Express(-like) servers. We meet it 1:1 until the else if (result.type === "MULTIPART_RESPONSE") { point.

In SvelteKit's Node adapter, the underlying server is actually made from the http library in Node, and we don't have access to the server in endpoints.

So, everything that can be returned needs to be returned all together.

Can we do anything to condense a multipart response or event stream?

@babichjacob babichjacob added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Nov 25, 2020
@babichjacob babichjacob removed the bug Something isn't working label Apr 2, 2021
@babichjacob
Copy link
Member Author

Upstream issue: sveltejs/kit#1563

@babichjacob babichjacob removed the help wanted Extra attention is needed label May 26, 2021
@ibilux
Copy link

ibilux commented Aug 21, 2021

Any updates about this ?

@babichjacob
Copy link
Member Author

Any updates about this ?

See the linked issue, which has been very active recently.

@ibilux
Copy link

ibilux commented Aug 21, 2021

See the linked issue, which has been very active recently.

Yeah I have been checking it, but to be honest I'm not familiar about streaming.
Is there any eta or a near solution ?

@babichjacob
Copy link
Member Author

Is there any eta or a near solution ?

It's up to there being an accepted resolution and implementation in SvelteKit core, but then I would need help updating this tool to make use of it—I don't personally know how GraphQL subscriptions or multipart responses work so I don't know how to implement or test them.

@ibilux
Copy link

ibilux commented Aug 21, 2021

@babichjacob we will try to implement it when they accepted and merge it.

@omar-shahid
Copy link

Is this project still alive? I would like to help with this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants