Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kit@110: removed lines from .gitignore in demo project #1581

Closed
frederikhors opened this issue May 29, 2021 · 2 comments · Fixed by #1924
Closed

kit@110: removed lines from .gitignore in demo project #1581

frederikhors opened this issue May 29, 2021 · 2 comments · Fixed by #1924
Milestone

Comments

@frederikhors
Copy link
Contributor

Describe the bug
From 1.0.0-next.110 in .gitignore of demo project are removed lines:

/build
/functions

and is added /package.

Is this a mistake?

WE still need /build in .gitignore, right?

@benmccann benmccann added this to the 1.0 milestone May 29, 2021
@benmccann
Copy link
Member

Yeah, I'd tend to agree. Though we may want to handle this on a per-adapter basis. See #1436 (comment) for more discussion

@jthegedus
Copy link
Contributor

jthegedus commented May 30, 2021

we may want to handle this on a per-adapter basis

I would like to voice again that Adapter specific ignore entries should be handled by the adapter or their instructions, not the default Kit template. /functions in the template may be useful for the Netlify adapter users with default dirs, but disadvantages those with non-default Netlify config, and more importantly other completely unrelated adapter users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants