Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvelteKit node adapter started failing after latest update #2098

Closed
lovasoa opened this issue Aug 4, 2021 · 2 comments
Closed

SvelteKit node adapter started failing after latest update #2098

lovasoa opened this issue Aug 4, 2021 · 2 comments

Comments

@lovasoa
Copy link
Contributor

lovasoa commented Aug 4, 2021

Describe the bug

After the latest update, SvelteKit node adapter started failing with:

> Using @sveltejs/adapter-node
 > .svelte-kit/node/intermediate/index.js:1:29: error: Could not resolve "../output/server/app.js"
    1 │ import { init, render } from '../output/server/app.js';
      ╵                              ~~~~~~~~~~~~~~~~~~~~~~~~~

> Build failed with 1 error:
.svelte-kit/node/intermediate/index.js:1:29: error: Could not resolve "../output/server/app.js"
Error: Build failed with 1 error:
.svelte-kit/node/intermediate/index.js:1:29: error: Could not resolve "../output/server/app.js"
    at failureErrorWithLog (/root/sanipasse/node_modules/esbuild/lib/main.js:1449:15)
    at /root/sanipasse/node_modules/esbuild/lib/main.js:1131:28
    at runOnEndCallbacks (/root/sanipasse/node_modules/esbuild/lib/main.js:1049:65)
    at buildResponseToResult (/root/sanipasse/node_modules/esbuild/lib/main.js:1129:7)
    at /root/sanipasse/node_modules/esbuild/lib/main.js:1236:14
    at /root/sanipasse/node_modules/esbuild/lib/main.js:609:9
    at handleIncomingPacket (/root/sanipasse/node_modules/esbuild/lib/main.js:706:9)
    at Socket.readFromStdout (/root/sanipasse/node_modules/esbuild/lib/main.js:576:7)
    at Socket.emit (node:events:394:28)
    at Socket.emit (node:domain:475:12)

Reproduction

I ran npm update and npm audit fix --force in sanipasse: https://github.com/lovasoa/sanipasse

Logs

No response

System Info

npx envinfo --system --binaries --browsers --npmPackages "{svelte,@sveltejs/*,vite}"

  System:
    OS: Linux 5.13 Fedora 34 (Workstation Edition) 34 (Workstation Edition)
    CPU: (8) x64 Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
    Memory: 2.13 GB / 15.28 GB
    Container: Yes
    Shell: 5.1.0 - /bin/bash
  Binaries:
    Node: 16.4.0 - /usr/bin/node
    Yarn: 1.22.10 - /usr/bin/yarn
    npm: 7.18.1 - /usr/bin/npm
  Browsers:
    Firefox: 90.0.2
  npmPackages:
    @sveltejs/adapter-node: next => 1.0.0-next.37 
    @sveltejs/adapter-static: next => 1.0.0-next.15 
    @sveltejs/kit: next => 1.0.0-next.142 
    svelte: ^3.38.3 => 3.42.1

Severity

blocking all usage of SvelteKit

Additional Information

No response

@lovasoa
Copy link
Contributor Author

lovasoa commented Aug 4, 2021

Fixed by : a12beb0#diff-162e563a978cd94e14ce386aabc0b584dec78659ec3d654e28bf832e5fd854ef

Maybe there could be some automated or manual testing before pushing to npm ? It looks like something that could be caught in CI...

@Conduitry
Copy link
Member

Closing as this was indeed fixed by #2096 and was published to npm.

There's not currently a good way to test adapters in CI. This is a known TODO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants