Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming prerender.pages option #2185

Closed
benmccann opened this issue Aug 13, 2021 · 3 comments · Fixed by #2380
Closed

Consider renaming prerender.pages option #2185

benmccann opened this issue Aug 13, 2021 · 3 comments · Fixed by #2380
Milestone

Comments

@benmccann
Copy link
Member

Describe the problem

prerender.pages config name is confusing. E.g. #1683

Describe the proposed solution

rename to something like:

  • prerender.entry
  • prerender.entryPoints
  • prerender.start
  • prerender.startPages

Alternatives considered

No response

Importance

nice to have

Additional Information

No response

@benmccann benmccann added this to the 1.0 milestone Aug 13, 2021
@Mlocik97
Copy link
Contributor

prerender.start is really dumb name... I think prerender.entry sound good.

@MarioDena
Copy link

+1 on prerender.entry

@benmccann
Copy link
Member Author

It looks like we can't simply rename it because pages is just a list of pages when crawl: false: https://kit.svelte.dev/docs#configuration-prerender

What might make more sense is to have crawl be a list of entry points to crawl and pages be a list of pages to directly prerender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants