Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno svelte kit #2472

Closed
elycheikhsmail opened this issue Sep 22, 2021 · 5 comments
Closed

deno svelte kit #2472

elycheikhsmail opened this issue Sep 22, 2021 · 5 comments

Comments

@elycheikhsmail
Copy link

Describe the problem

svelte kit is great project, but building it using node runtime make it difficule to maintain: security pb and modularity system ( node module)

Describe the proposed solution

svelte kit is great project, but why not use deno instead of node ? this may be a new project but it will not be from scrach.
existing adapter can be updated or rewriting to work.
there are many benefit of using deno :

  • good dev experience ( no node_module)
  • easy debug, most of deno module are ts
  • no loosing all existing work in deno svelte since we use the kanguage
  • using existing hosting plus deno deploy
  • and more

Alternatives considered

No response

Importance

would make my life easier

Additional Information

No response

@adebisi-fa
Copy link

adebisi-fa commented Sep 22, 2021

This looks like something an deno adapter like this, adapter-deno can fix. Is it possible you try this out?

@Conduitry
Copy link
Member

SvelteKit depends on a number of other projects (notably Vite) that only work in Node. You can use an adapter to produce a build that can run on Deno in production. but it's not even remotely practical for the development experience to also use Deno.

@DefinitelyMaybe
Copy link

hey could we re-visit this now that deno supports npm and vite?

I've been playing around trying to get deno to run my svelte-kit starter template but coming up with errors atm.

$ deno task dev
Task dev deno run -A --node-modules-dir npm:vite


  VITE v3.2.4  ready in 1057 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
TypeError: types.isProxy is not a function
    at Object.record<ByteString, ByteString> (file:///home/aaron/Documents/threlte-BVH/node_modules/.deno/[email protected]/node_modules/undici/lib/fetch/webidl.js:267:16)
    at Object.webidl.converters.HeadersInit (file:///home/aaron/Documents/threlte-BVH/node_modules/.deno/[email protected]/node_modules/undici/lib/fetch/headers.js:493:63)
    at new Headers (file:///home/aaron/Documents/threlte-BVH/node_modules/.deno/[email protected]/node_modules/undici/lib/fetch/headers.js:169:32)
    at ServerResponse.<instance_members_initializer> (https://deno.land/[email protected]/node/http.ts:244:14)
    at new ServerResponse (https://deno.land/[email protected]/node/http.ts:267:5)
    at https://deno.land/[email protected]/node/http.ts:579:23
    at new Promise (<anonymous>)
    at handler (https://deno.land/[email protected]/node/http.ts:578:16)
    at Object.serve (deno:ext/flash/01_http.js:559:24)
    at async Promise.all (index 0)

or maybe someone can point me in the right direction?

@elycheikhsmail
Copy link
Author

hey could we re-visit this now that deno supports npm and vite?

I've been playing around trying to get deno to run my svelte-kit starter template but coming up with errors atm.

$ deno task dev
Task dev deno run -A --node-modules-dir npm:vite


  VITE v3.2.4  ready in 1057 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
TypeError: types.isProxy is not a function
    at Object.record<ByteString, ByteString> (file:///home/aaron/Documents/threlte-BVH/node_modules/.deno/[email protected]/node_modules/undici/lib/fetch/webidl.js:267:16)
    at Object.webidl.converters.HeadersInit (file:///home/aaron/Documents/threlte-BVH/node_modules/.deno/[email protected]/node_modules/undici/lib/fetch/headers.js:493:63)
    at new Headers (file:///home/aaron/Documents/threlte-BVH/node_modules/.deno/[email protected]/node_modules/undici/lib/fetch/headers.js:169:32)
    at ServerResponse.<instance_members_initializer> (https://deno.land/[email protected]/node/http.ts:244:14)
    at new ServerResponse (https://deno.land/[email protected]/node/http.ts:267:5)
    at https://deno.land/[email protected]/node/http.ts:579:23
    at new Promise (<anonymous>)
    at handler (https://deno.land/[email protected]/node/http.ts:578:16)
    at Object.serve (deno:ext/flash/01_http.js:559:24)
    at async Promise.all (index 0)

or maybe someone can point me in the right direction?

you can discus about this in deno discor, you can get help there

@DefinitelyMaybe
Copy link

cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants