Remove relative path references in adapters

[benmccann]

Describe the bug

The best idea I have so far is that instead of writing the server output to .svelte-kit/output/server, we could try writing it to something like node_modules/@sveltejs/user-app (or maybe src/node_modules like Sapper does) with a package.json file:

		{
			"name": "@sveltejs/user-app",
			"version": "0.0.1",
			"private": true,
			"type": "module",
			"main": "app.js"
		}

The relative path is stopping adapter authors from using the types

I also think that after this is fixed that we can use Vite to do a single build pass instead of doing a second build step with esbuild in the adapters

Reproduction

For example:

kit/packages/adapter-node/src/middlewares.js

Line 1 in ff35e8d

// TODO hardcoding the relative location makes this brittle

We should make sure @jthegedus can consume the types in the firebase adapter after this is fixed

Logs

No response

System Info

`master`

Severity

annoyance

Additional Information

No response

[Mlocik97]

I don't think it's good idea to write this to src/node_modules (it caused problems in Sapper). I agree we need to solve those relative paths, but there should be maybe better way?

[benmccann]

What problems did it cause in Sapper?

[Mlocik97]

sveltejs/sapper#1696

for example...

there is at least 10 similiar issues on Sapper Github.

One even more critical, about bundlers, as it's problematic to process src/node_modules/, (I'm lazy for searching issues)

Also I think Rich was talking about how he wanted to get rid of this, as beginners were often confused with this folder. It's even why in Kit tried new approach with .svelte-kit/ folder

[benmccann]

That issue sounds like people didn't like using src/node_modules/images (as is done in the template). SvelteKit doesn't do that and instead uses Vite aliases, so I don't think that issue is relevant.

Still, we should probably put it directly in node_modules as I think src/node_modules was confusing to people. The Sapper FAQ seems to suggest adding a new dependency would nuke it if put directly in node_modules, but that doesn't sound right to me. We should test

[Mlocik97]

what about putting node_modules to .svelte-kit ? I think having .svelte-kit/node_modules/ is best solution, bcs, it's not wiped when installing new dep,... it's not inside src/so it doesn't confuse people as it is in hidden generated folder.

[benmccann]

No longer an issue:

kit/packages/adapter-node/src/handler.js

Line 7 in 7b79522

import { App } from 'APP';