Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'svelte'

[binajmen]

Describe the bug

I successfully deployed my SvelteKit on Fly.io (using the Node adapter).

Unfortunately, I got the following error:

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'svelte' imported from /myapp/node_modules/typesafe-i18n/svelte/index.mjs
   at new NodeError (node:internal/errors:387:5)  
   at packageResolve (node:internal/modules/esm/resolve:951:9)  
   at moduleResolve (node:internal/modules/esm/resolve:1000:20) 
   at defaultResolve (node:internal/modules/esm/resolve:1214:11)  
   at nextResolve (node:internal/modules/esm/loader:165:28) 
   at ESMLoader.resolve (node:internal/modules/esm/loader:844:30) 
   at ESMLoader.getModuleJob (node:internal/modules/esm/loader:431:18)  
   at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:40) 
   at link (node:internal/modules/esm/module_job:75:36)

Reproduction

Unfortunately, I'm unable to reproduce in local 😕

Is there a link with #1257 or #3137 or is it an issue with typesafe-i18n itself?

Logs

No response

System Info

System:
    OS: macOS 12.5.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 489.64 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.8.0 - ~/.nvm/versions/node/v18.8.0/bin/node
    npm: 8.18.0 - ~/.nvm/versions/node/v18.8.0/bin/npm
  Browsers:
    Brave Browser: 105.1.43.89
    Chrome: 105.0.5195.102
    Safari: 15.6.1
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.71 
    @sveltejs/adapter-node: next => 1.0.0-next.88 
    @sveltejs/kit: ^1.0.0-next.483 => 1.0.0-next.483 
    svelte: ^3.50.1 => 3.50.1 
    vite: ^3.1.0 => 3.1.0

Severity

blocking all usage of SvelteKit

Additional Information

No response

[binajmen]

Is this #1450 (comment) confirmed?

For @sveltejs/adapter-node
"@sveltejs/kit": "next"
"svelte": "^3.34.0"
are needed as (production) dependencies.

[binajmen]

So I switched the svelte package from dev (-D) to prod (-P) dependency, redeployed, and it is now working.

Although, from the previous issues, I understand this is not good/expected:

In the meantime as a workaround, you can move @sveltejs/kit and any other dependencies your app needs at runtime from devDependencies to dependencies but this obviously isn't a great solution.

[Rich-Harris]

Does the same thing happen if you run node build after building the app locally? If so, you can provide a reproduction. My guess would be that typesafe-i18n is a prod dependency in your app, and since it has svelte as an undeclared peer dependency, svelte must also be a prod dependency.

If that's the case, I suggest trying to move typesafe-i18n to devDependencies.

[Rich-Harris]

cc'ing @ivanhofer for visibility as well 👋

[ivanhofer]

@binajmen you can add typesafe-i18n to the devDependencies but then you need to instruct vite to also add typesafe-i18n to your bundle. Adding those lines should fix the issue for you:

vite.config.js

export default defineConfig({
	plugins: [sveltekit()],
+	ssr: {
+		noExternal: ['typesafe-i18n'],
+	},
})

[binajmen]

@binajmen you can add typesafe-i18n to the devDependencies but then you need to instruct vite to also add typesafe-i18n to your bundle. Adding those lines should fix the issue for you:

@ivanhofer This solve the issue indeed 👍 I don't fully understand the impact though. Is there one? Is this more a workaround that a final solution? Should we continue to track the issue or can it be closed?

Does the same thing happen if you run node build after building the app locally? If so, you can provide a reproduction.

@Rich-Harris Unfortunately I'm unable to reproduce locally. I'm not sure why.. If you think it should be further investigated, I don't mind take the time (later this week) to create a small repro of my current project. This is non blocking so the milestone whenever tag is appropriated 😉

[ivanhofer]

I don't fully understand the impact though. Is there one? Is this more a workaround that a final solution? Should we continue to track the issue or can it be closed?

I would see this as a final solution. It does not really matter if you bundle typesafe-i18n into your production application or to have it installed as a dependency.

Unfortunately I'm unable to reproduce locally. I'm not sure why..

The issue is that Fly.io (and most other node hosting services) get rid of all devDependencies once the build process was completed. In order to reproduce this locally, you would need to:

1. run the build process
2. manually uninstall all devDependencies
3. start the application

[binajmen]

I would see this as a final solution.

Then I can safely close this issue as it solves my problem 👍

The issue is that Fly.io (and most other node hosting services) get rid of all devDependencies

In my case, based on some inspiration I found on the web (being a Docker beginner), I run:

RUN npm prune --production

Which gets rid of devDependencies, indeed. I'll stick to your solution ;)